Skip to content

Commit 396b157

Browse files
authored
Close HttpClient to prevent hang on exit. (#3992)
* Close HttpClient to prevent hang on exit. * Update CHANGELOG.md.
1 parent d942921 commit 396b157

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

build_resolvers/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
- Move `BuildStepImpl` to `build_runner_core`, use `SingleStepReader` directly.
1111
- Stop building `transitive_digest` files by default.
1212
- Use `LibraryCycleGraphLoader` to load transitive deps for analysis.
13+
- Bug fix: fix delay on shutdown for fast builds when the "analyzer out of
14+
date" warning is displayed.
1315

1416
## 2.4.4
1517

build_resolvers/lib/src/resolver.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,8 +550,9 @@ class AnalyzerResolvers implements Resolvers {
550550
void _warnOnLanguageVersionMismatch() async {
551551
if (sdkLanguageVersion <= ExperimentStatus.currentVersion) return;
552552

553+
HttpClient? client;
553554
try {
554-
var client = HttpClient();
555+
client = HttpClient();
555556
var request = await client.getUrl(
556557
Uri.https('pub.dartlang.org', 'api/packages/analyzer'),
557558
);
@@ -616,6 +617,8 @@ SDK language version: $sdkLanguageVersion
616617
Please ensure you are on the latest `analyzer` version, which can be seen at
617618
https://pub.dev/packages/analyzer.
618619
''');
620+
} finally {
621+
client?.close();
619622
}
620623
}
621624

0 commit comments

Comments
 (0)