only run in shell when on windows and running a .bat file #252
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
| runInShell: | ||
| // Required when running .bat files on windows, but otherwise should | ||
| // be avoided. | ||
| io.Platform.isWindows && commandWithPaths.first.endsWith('.bat'), |
There was a problem hiding this comment.
Are you doing any escaping of the command/args before here, or does that just happen inside processManager when runInShell is true? (you probably don't want any escaping when this is false).
You might also want to include .cmd for completeness (I didn't in Dart-Code because I know the only Windows shell scripts are flutter.bat).
I don't know how this works for non-Windows. I presume it you use a shell script that has a shebang line it'll just spawn the shell anyway (Dart-Code never uses shell execute for non-Windows).
There was a problem hiding this comment.
Are you doing any escaping of the command/args before here, or does that just happen inside
processManagerwhenrunInShellis true? (you probably don't want any escaping when this is false).
Nothing is happening before here (or at all by us)
|
autosubmit label was removed for dart-lang/ai/252, because - The status or check suite build (master, windows-latest) has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Re-running the failed job to make sure it was a flake |
Based on this suggestion from @DanTup dart-lang/tools#2138 (comment)