Skip to content

improve tool description for the dtd connection tool and improve error messages #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

improve tool description for the dtd connection tool and improve error messages #178

merged 3 commits into from
Jun 18, 2025

Conversation

jakemac53
Copy link
Contributor

Closes #177

@jakemac53 jakemac53 requested a review from kenzieschmoll June 18, 2025 16:51
@jakemac53 jakemac53 mentioned this pull request Jun 18, 2025
Closed
@github-actions GitHub Actions
Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

DanTup
DanTup reviewed Jun 18, 2025
View reviewed changes
pkgs/dart_mcp_server/lib/src/mixins/dtd.dart Outdated
@@ -604,7 +615,8 @@ base mixin DartToolingDaemonSupport
description:
'Connects to the Dart Tooling Daemon. You should ask the user for the '
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should ask the user

I wonder if we should be less explicit here? The default model I get in Copilot Chat (GPT-4.1) seems to do what we want (use the tool) anyway, but since you added "Do not just make up a random URI" I'm not sure if they're all going to be that smart 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if they have the tool to get the URI, they will use it (even without that text to not make one up).

Maybe we should be a bit less prescriptive here though, given there are going to be tools available in some environments now, and the user doesn't always have to provide it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps something like "This should come from a suitable tool or from the user, ..."?

Specifying logic in English like this feels really weird 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the text

kenzieschmoll
kenzieschmoll reviewed Jun 18, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:dart_mcp 0.2.2 ready to publish dart_mcp-v0.2.2

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@jakemac53 jakemac53 merged commit 3ab9482 into main Jun 18, 2025
15 checks passed
@jakemac53 jakemac53 deleted the connect-to-dtd-errors branch June 18, 2025 17:39
DanTup
DanTup reviewed Jun 18, 2025
View reviewed changes
pkgs/dart_mcp_server/lib/src/mixins/dtd.dart
'Connects to the Dart Tooling Daemon. You should get the uri either '
'from available tools or the user, do not just make up a random URI to '
'pass. When asking the user for the uri, you should suggest the "Copy '
'DTD Uri to clipboard" action. Do . When reconnecting after losing a '
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "Do ." was intended to be left here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops!

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 23, 2025
@devoncarew
[deps] rev ai, core, dartdoc, ecosystem, web, webdev
ec00453 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/f2b48c6..12ac0a4):
  12ac0a4  2025-06-18  Jacob MacDonald  make the log file test less flaky by retrying deletes and reads (dart-lang/ai#180)
  dbedc6d  2025-06-18  Jacob MacDonald  fix cruft in description (dart-lang/ai#179)
  3ab9482  2025-06-18  Jacob MacDonald  improve tool description for the dtd connection tool and improve error messages (dart-lang/ai#178)
  4ca0ff1  2025-06-18  Jacob MacDonald  Use shared Implementation type, add clientInfo field to MCPServer (dart-lang/ai#175)
  885a4c5  2025-06-18  Jacob MacDonald   Add `--log-file` argument to log all protocol traffic to a file (dart-lang/ai#176)
  7ca3eba  2025-06-17  Nate Bosch  Add JSON schema for test runner arguments (dart-lang/ai#169)

core (https://github.com/dart-lang/core/compare/dc97530..b59ecf4):
  b59ecf4c  2025-06-18  Lasse R.H. Nielsen  Optimize surrogate decoding. (dart-lang/core#894)

dartdoc (https://github.com/dart-lang/dartdoc/compare/4ceea6b..f1fe177):
  f1fe1775  2025-06-16  Sarah Zakarias  Refactor 404 error page to use div instead of p for search form (dart-lang/dartdoc#4064)

ecosystem (https://github.com/dart-lang/ecosystem/compare/64aac3a..d5233c6):
  d5233c6  2025-06-13  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/ecosystem#351)

web (https://github.com/dart-lang/web/compare/c8c1c28..4b2f02e):
  4b2f02e  2025-06-18  nikeokoronkwo  Add Variable Declaration Support (dart-lang/web#382)

webdev (https://github.com/dart-lang/webdev/compare/661dafd..6dc3dde):
  6dc3ddef  2025-06-20  Jessy Yameogo  Fix duplicate connection/logs in Webdev (dart-lang/webdev#2635)
  0c8a17b4  2025-06-20  Morgan :)  Remove dependency overrides. (dart-lang/webdev#2634)
  a3218638  2025-06-16  Jessy Yameogo  modifying DWDS Injector to always inject client and introduce useDwdsWebSocketConnection flag (dart-lang/webdev#2629)
  2eb27546  2025-06-16  Morgan :)  Prepare for `build_runner` changes. (dart-lang/webdev#2633)

Change-Id: Ib323bea37dd77ed94387e77d9c504f889bfa8050
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/436021
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanTup DanTup DanTup approved these changes

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
package:dart_mcp_server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the error message when "Connect to DTD" tool fails
3 participants
@jakemac53 @DanTup @kenzieschmoll