Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: remove duplicated highlights and ignore void function calls #829

Merged
merged 4 commits into from
May 16, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

@incendial incendial requested a review from dkrutskikh May 4, 2022 17:54
@incendial incendial self-assigned this May 4, 2022
@incendial incendial added this to the 4.16.0 milestone May 4, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented May 4, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 424

  • Total lines of source code: 7448

  • Total classes: 290

  • Average Cyclomatic Number per line of code: 0.35

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1310.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #829 (b532ffa) into master (20a82cc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         279      279           
  Lines        5932     5934    +2     
=======================================
+ Hits         5180     5182    +2     
  Misses        752      752           
Impacted Files Coverage Δ
.../rules_list/prefer_moving_to_variable/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a82cc...b532ffa. Read the comment docs.

@incendial incendial changed the title fix: remove duplicated and ignore void function calls fix: remove duplicated highlights and ignore void function calls May 5, 2022
@dkrutskikh dkrutskikh merged commit 7b09a55 into master May 16, 2022
@dkrutskikh dkrutskikh deleted the improve-prefer-moving-to-variable branch May 16, 2022 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants