Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: list-all-equatable-fields should be typed common #1141

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ import '../../../lint_utils.dart';
import '../../../models/internal_resolved_unit_result.dart';
import '../../../models/issue.dart';
import '../../../models/severity.dart';
import '../../models/flutter_rule.dart';
import '../../models/common_rule.dart';
import '../../rule_utils.dart';

part 'visitor.dart';

class ListAllEquatableFieldsRule extends FlutterRule {
class ListAllEquatableFieldsRule extends CommonRule {
static const ruleId = 'list-all-equatable-fields';

ListAllEquatableFieldsRule([
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import 'package:dart_code_metrics/src/analyzers/lint_analyzer/models/severity.dart';
import 'package:dart_code_metrics/src/analyzers/lint_analyzer/rules/models/rule_type.dart';
import 'package:dart_code_metrics/src/analyzers/lint_analyzer/rules/rule_utils.dart';
import 'package:dart_code_metrics/src/analyzers/lint_analyzer/rules/rules_list/list_all_equatable_fields/list_all_equatable_fields_rule.dart';
import 'package:test/test.dart';

Expand All @@ -8,6 +10,22 @@ const _examplePath = 'list_all_equatable_fields/examples/example.dart';

void main() {
group('ListAllEquatableFieldsRule', () {
test('is of type common', () {
expect(
ListAllEquatableFieldsRule().type,
equals(RuleType.common),
);
});

test('has expected documentation path', () {
final documentationUri = documentation(ListAllEquatableFieldsRule());

expect(
documentationUri.path,
equals('/docs/rules/common/list-all-equatable-fields'),
);
});

test('initialization', () async {
final unit = await RuleTestHelper.resolveFromFile(_examplePath);
final issues = ListAllEquatableFieldsRule().check(unit);
Expand Down