This repository was archived by the owner on Jan 14, 2025. It is now read-only.
rev to 2.1.3 in preparation for release #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devoncarew
commented
Nov 11, 2022
devoncarew
commented
- update the changelog to capture the previous commit (it turns out that the API signature changes - which looked fairly minor - are effecting package consumers)
- rev to 2.1.3 in preparation for release
kevmoo
approved these changes
Nov 11, 2022
|
Are these changes breaking consumers, or only breaking consumers with particularly strict linting? |
|
Exactly!
…On Fri, Nov 11, 2022, 14:11 Nate Bosch ***@***.***> wrote:
Are these changes breaking consumers, or only breaking consumers with
particularly strict linting?
—
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEFCV34MODKSBBEOKT6RLWH2773ANCNFSM6AAAAAAR56OJDU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
What I mean is - we had to hold this package back because it broke google3 right? Was the breakage limited to strict checking, or did something break more seriously? |
|
Pretty sure it was a lint
…On Fri, Nov 11, 2022, 14:17 Nate Bosch ***@***.***> wrote:
What I mean is - we had to hold this package back because it broke google3
right?
Was the breakage limited to strict checking, or did something break more
seriously?
—
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEFCVZLHUL362Y4UHMN7DWH3AX5ANCNFSM6AAAAAAR56OJDU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
It was just strict checking - failing the analyze because a cast was no longer necessary. |
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
* rev to 2.1.3 in preparation for release * Update CHANGELOG.md Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.