Skip to content
This repository was archived by the owner on Oct 18, 2024. It is now read-only.

Commit e04942d

Browse files
authored
update min SDK and deps (#155)
1 parent a03a946 commit e04942d

File tree

5 files changed

+21
-23
lines changed

5 files changed

+21
-23
lines changed

.github/workflows/test-package.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
matrix:
22-
sdk: [stable]
22+
sdk: [dev]
2323
steps:
2424
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
2525
- uses: dart-lang/setup-dart@ca7e6fee45ffbd82b555a7ebfc236d2c86439f5b
@@ -44,7 +44,7 @@ jobs:
4444
matrix:
4545
# Add macos-latest and/or windows-latest if relevant for this package.
4646
os: [ubuntu-latest]
47-
sdk: [2.19.0, stable, beta]
47+
sdk: [3.2, dev]
4848
steps:
4949
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
5050
- uses: dart-lang/setup-dart@ca7e6fee45ffbd82b555a7ebfc236d2c86439f5b

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.2.1-wip
2+
3+
* Require Dart 3.2
4+
15
## 1.2.0
26

37
* Add notification when the log level is changed. Logger `onLevelChanged` broadcasts a stream of level values.

analysis_options.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,21 @@ linter:
1111
- avoid_classes_with_only_static_members
1212
- avoid_private_typedef_functions
1313
- avoid_redundant_argument_values
14-
- avoid_returning_null_for_future
1514
- avoid_returning_this
1615
- avoid_unused_constructor_parameters
1716
- avoid_void_async
1817
- cancel_subscriptions
19-
- comment_references
2018
- join_return_with_assignment
2119
- literal_only_boolean_expressions
2220
- missing_whitespace_between_adjacent_strings
2321
- no_adjacent_strings_in_list
2422
- no_runtimeType_toString
2523
- package_api_docs
26-
- prefer_const_constructors
2724
- prefer_const_declarations
2825
- prefer_expression_function_bodies
2926
- prefer_final_locals
30-
- prefer_relative_imports
31-
- test_types_in_equals
3227
- unnecessary_await_in_return
3328
- unnecessary_raw_strings
3429
- use_if_null_to_convert_nulls_to_bools
3530
- use_raw_strings
3631
- use_string_buffers
37-
- use_super_parameters

pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: logging
2-
version: 1.2.0
2+
version: 1.2.1-wip
33
description: >-
44
Provides APIs for debugging and error logging, similar to loggers in other
55
languages, such as the Closure JS Logger and java.util.logging.Logger.
66
repository: https://github.com/dart-lang/logging
77

88
environment:
9-
sdk: '>=2.19.0 <4.0.0'
9+
sdk: ^3.2.0
1010

1111
dev_dependencies:
12-
dart_flutter_team_lints: ^1.0.0
12+
dart_flutter_team_lints: ^2.0.0
1313
test: ^1.16.0

test/logging_test.dart

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ void main() {
240240

241241
test('children is empty', () {
242242
final a = Logger.detached('a');
243-
expect(a.children, {});
243+
expect(a.children, <Object, Object>{});
244244
});
245245

246246
test('have levels independent of the root level', () {
@@ -409,7 +409,7 @@ void main() {
409409

410410
test('logging methods store appropriate level', () {
411411
root.level = Level.ALL;
412-
final rootMessages = [];
412+
final rootMessages = <String>[];
413413
root.onRecord.listen((record) {
414414
rootMessages.add('${record.level}: ${record.message}');
415415
});
@@ -439,7 +439,7 @@ void main() {
439439

440440
test('logging methods store exception', () {
441441
root.level = Level.ALL;
442-
final rootMessages = [];
442+
final rootMessages = <String>[];
443443
root.onRecord.listen((r) {
444444
rootMessages.add('${r.level}: ${r.message} ${r.error}');
445445
});
@@ -485,9 +485,9 @@ void main() {
485485

486486
test('message logging - no hierarchy', () {
487487
root.level = Level.WARNING;
488-
final rootMessages = [];
489-
final aMessages = [];
490-
final cMessages = [];
488+
final rootMessages = <String>[];
489+
final aMessages = <String>[];
490+
final cMessages = <String>[];
491491
c.onRecord.listen((record) {
492492
cMessages.add('${record.level}: ${record.message}');
493493
});
@@ -536,9 +536,9 @@ void main() {
536536

537537
b.level = Level.WARNING;
538538

539-
final rootMessages = [];
540-
final aMessages = [];
541-
final cMessages = [];
539+
final rootMessages = <String>[];
540+
final aMessages = <String>[];
541+
final cMessages = <String>[];
542542
c.onRecord.listen((record) {
543543
cMessages.add('${record.level}: ${record.message}');
544544
});
@@ -602,7 +602,7 @@ void main() {
602602

603603
test('message logging - lazy functions', () {
604604
root.level = Level.INFO;
605-
final messages = [];
605+
final messages = <String>[];
606606
root.onRecord.listen((record) {
607607
messages.add('${record.level}: ${record.message}');
608608
});
@@ -624,8 +624,8 @@ void main() {
624624

625625
test('message logging - calls toString', () {
626626
root.level = Level.INFO;
627-
final messages = [];
628-
final objects = [];
627+
final messages = <String>[];
628+
final objects = <Object?>[];
629629
final object = Object();
630630
root.onRecord.listen((record) {
631631
messages.add('${record.level}: ${record.message}');

0 commit comments

Comments
 (0)