Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map: Click on image does not center map #18143

Closed
andju opened this issue Jan 3, 2025 · 3 comments · Fixed by #18165
Closed

Map: Click on image does not center map #18143

andju opened this issue Jan 3, 2025 · 3 comments · Fixed by #18165
Assignees
Labels
bug: pending someone needs to start working on that priority: high core features are broken and not usable at all, software crashes reproduce: confirmed a way to make the bug re-appear 99% of times has been found scope: DAM managing files, collections, archiving, metadata, etc. scope: UI user interface and interactions
Milestone

Comments

@andju
Copy link

andju commented Jan 3, 2025

Describe the bug

When in map view: If I click on an image thumbnail, the map should Center on the respective image (worked until version 4.8.1). With version 5.0.0 nothing happens when clicking on an thumbnail.

Steps to reproduce

  1. Click on "other" in the upper right corner.
  2. Click on "Map".
  3. Show the lower thumbnail bar (if not visible).
  4. Click on an image that is located outside the current map view.

Expected behavior

Center the map on the clicked image.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

5.0.0

What OS are you using?

Windows

What is the version of your OS?

Windows 10 Pro

Describe your system?

No response

Are you using OpenCL GPU in darktable?

I dont know

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

@andju andju changed the title Map: Double-click does not center image Map: Click on image does not center map Jan 3, 2025
@ralfbrown ralfbrown added scope: UI user interface and interactions reproduce: confirmed a way to make the bug re-appear 99% of times has been found labels Jan 4, 2025
@ralfbrown
Copy link
Collaborator

Confirmed in current master under Linux.

@zisoft
Copy link
Collaborator

zisoft commented Jan 4, 2025

@TurboGit: This was introduced by cc07d2b

Map and print modules are not handled.

case DT_THUMBTABLE_MODE_FILMSTRIP:
if(dt_view_get_current() == DT_VIEW_DARKROOM)
{
if(table->sel_single_cb != 0)
{
g_source_remove(table->sel_single_cb);
table->sel_single_cb = 0;
}
// disable next BUTTON_RELEASE event (see _event_motion_release)
table->to_selid = -1;
// unselect currently edited picture, select new one
dt_selection_deselect(darktable.selection,
darktable.develop->image_storage.id);
dt_selection_select(darktable.selection, id);
DT_CONTROL_SIGNAL_RAISE(DT_SIGNAL_VIEWMANAGER_THUMBTABLE_ACTIVATE, id);
return FALSE;
}
default:
break;
}

@TurboGit TurboGit added priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc. bug: pending someone needs to start working on that labels Jan 4, 2025
@TurboGit TurboGit added this to the 5.0.1 milestone Jan 4, 2025
@TurboGit TurboGit self-assigned this Jan 4, 2025
@TurboGit
Copy link
Member

TurboGit commented Jan 4, 2025

I'll try to have a look soon... If someone want to pick this one go ahead and tell me before I start looking.

TurboGit added a commit that referenced this issue Jan 6, 2025
For the print view a single click must change the current printed image.
For the map view a single click must center the picture if present on the map.

Fixes #18143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending someone needs to start working on that priority: high core features are broken and not usable at all, software crashes reproduce: confirmed a way to make the bug re-appear 99% of times has been found scope: DAM managing files, collections, archiving, metadata, etc. scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants