Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panasonic Lumix DC-S5D #18117

Open
djwaverider opened this issue Dec 30, 2024 · 7 comments
Open

Panasonic Lumix DC-S5D #18117

djwaverider opened this issue Dec 30, 2024 · 7 comments
Assignees
Labels
scope: camera support adding WB and raw support for new cameras
Milestone

Comments

@djwaverider
Copy link

Hello,
I tried to import my raw files in darktable v5.0.0 but files are not supported.
raw.Pixls.us is not reachable then I uploaded on figshare CC0 :

https://figshare.com/account/articles/28107128

I hope it can help the darkatble community.

Warm regards.

@djwaverider djwaverider added the scope: camera support adding WB and raw support for new cameras label Dec 30, 2024
@kmilos
Copy link
Contributor

kmilos commented Dec 30, 2024

Thank you for the samples!

@victoryforce
Copy link
Collaborator

I uploaded on figshare CC0 :

https://figshare.com/account/articles/28107128

@djwaverider
At the specified URL I only see the message "the page cannot be found".
What am I doing wrong? Maybe I have to login to figshare account to have access?

@kmilos
Copy link
Contributor

kmilos commented Jan 2, 2025

Indeed, same here, already expired? Please provide a permanent, and public link.

@djwaverider
Copy link
Author

Let me know if with this link you can download photos
https://doi.org/10.6084/m9.figshare.28107128.v1
Regards

@victoryforce
Copy link
Collaborator

Yes, this link works, I can download two raw files. Thanks!

@victoryforce
Copy link
Collaborator

So, a few observations:

  • Adobe DNG Converter supports this model. It shows the same matrix as for the S5 model. This is consistent with information on the web that these models have the same sensor. The S5D model seems to contain only modifications that do not related to the sensor and its data processing, such as compatibility with DJI’s LiDAR autofocus system.

  • Adobe DNG Converter for an image from the S5D places a "UniqueCameraModel" tag in the DNG with the value Panasonic DC-S5, while the "LocalizedCameraModel" contains Panasonic DC-S5D. In other words, ADC considers the S5D model to be just a localization for certain markets of the S5 model.

  • The two facts mentioned above warrant adding a new camera as just an alias to the S5.

  • ADC indicates the black level as 510 (for both the S5 and the S5D). The same value was in the original PR that added S5 support. But somehow in a later commit this value was changed to 509, which seems wrong.

  • I understand that changing the black level value for S5 from 509 to 510 will change the look of existing user edits, but I think it's worth doing.

I'll think about it a bit more, but I'll probably propose a PR with the alias and the black level tweak.

@kmilos
Copy link
Contributor

kmilos commented Jan 4, 2025

I'll probably propose a PR with the alias and the black level tweak

Thanks for checking out the samples w/ ADC. Sounds like just the alias addition should suffice, the black level is actually read each time from the raw file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: camera support adding WB and raw support for new cameras
Projects
None yet
Development

No branches or pull requests

4 participants