Skip to content

Commit 11e1d29

Browse files
committed
Fixed for node8!. Updated package.json libs. Thanks Keith! :)
1 parent 4a015d2 commit 11e1d29

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424
"author": "Keith Cirkel <npm@keithcirkel.co.uk> (http://keithcirkel.co.uk/)",
2525
"license": "MIT",
2626
"devDependencies": {
27-
"bluebird": "^2.9.25",
28-
"chai": "^2.3.0",
29-
"coffee-script": "^1.9.2",
30-
"mocha": "^2.2.4"
27+
"bluebird": "^3.5.0",
28+
"chai": "^4.0.2",
29+
"coffee-script": "^1.12.6",
30+
"mocha": "^3.4.2"
3131
}
3232
}

test/index.coffee

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ cmdWrapper = (cmd) ->
3232

3333
spawnParallelshell = (cmd) ->
3434
return spawn sh, [shArg, cmdWrapper("node ./index.js "+cmd )], {
35-
cwd: process.cwd
35+
cwd: process.cwd()
3636
}
3737

3838
killPs = (ps) ->
@@ -67,6 +67,7 @@ describe "parallelshell", ->
6767
Promise.all([testOutput("-h", usageInfo), testOutput("--help", usageInfo)])
6868
.then -> done()
6969
.catch done
70+
return
7071

7172
it "should close with exitCode 1 on child error", (done) ->
7273
ps = spawnParallelshell(failingProcess)
@@ -85,7 +86,7 @@ describe "parallelshell", ->
8586
setTimeout (() ->
8687
should.not.exist(ps.signalCode)
8788
killPs(ps)
88-
),50
89+
),25
8990

9091

9192
it "should close sibling processes on child error", (done) ->
@@ -105,11 +106,13 @@ describe "parallelshell", ->
105106
should.not.exist(ps2.signalCode)
106107
killPs(ps)
107108
killPs(ps2)
108-
),50
109+
),25
109110
Promise.all [new Promise((resolve) -> ps.on("close",resolve)),
110111
new Promise (resolve) -> ps2.on("close",resolve)]
111112
.then -> done()
112113
.catch done
114+
return
115+
113116
it "should close on CTRL+C / SIGINT", (done) ->
114117
ps = spawnParallelshell(["-w",waitingProcess,failingProcess,waitingProcess].join(" "))
115118
spyOnPs ps,2

0 commit comments

Comments
 (0)