Commit 7b2c803
committed
Fix incorrect assignment in Mobject.put_start_and_end_on
PR ManimCommunity#3718 changed the behavior of `Mobject.put_start_and_end_on` when
`start == end`, however the assigment to `self.points` was
incorrect. The existing code assigned the Point3D directly to
`self.points`, that then becomes an array with shape `(3,)`, while
instead it should really have shape `(1, 3)`.
PR ManimCommunity#4027 added a comment that this should be fixed, but did not fix
the issue. The comment is now superfluous.
This commit fixes the incorrect code and associated test.1 parent 7879fe4 commit 7b2c803
File tree
2 files changed
+6
-8
lines changed- manim/mobject
- tests/module/mobject/graphing
2 files changed
+6
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1776 | 1776 | | |
1777 | 1777 | | |
1778 | 1778 | | |
1779 | | - | |
1780 | | - | |
1781 | | - | |
1782 | | - | |
| 1779 | + | |
1783 | 1780 | | |
1784 | 1781 | | |
1785 | 1782 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
130 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
131 | 132 | | |
132 | | - | |
| 133 | + | |
0 commit comments