Memory leak on RxBleInternalScanResult for long scanning period

[lukevr]

Summary

Objects RxBleInternalScanResult are not collected by GC, in case when phone scans for a long time. The speed of scanning(e.g. passing rxBleScanResult to subscriber) goes down dramatically.

Preconditions

Long lastScanTime = 0;

Subscription scanSubscription = rxBleClient.scanBleDevices()
.subscribe(
rxBleScanResult -> {
// Process scan result here.
long currTime = currentTimeMillis();
Log.i(TAG, "Delay between results: " + (currTime - lastScanTime));
lastScanTime = currTime;
},
throwable -> {
// Handle an error here.
}
);

Steps to reproduce actual result

1. 3-5 BLE services should advertise in one room, Run App, keep Activity active.
2. See unexpected "Delay between results" after 15-20 min in Logcat
3. See continues growing of RxBleInternalScanResult objects in Dumped Java Heaps

Actual result

The amount of RxBleInternalScanResult keeps growing, the performance of scanning goes down.

Expected result

GC collects old RxBleInternalScanResult, the performance of scanning is stable.

[dariuszseweryn]

Fixed with b53d840
Should be available in 1.2.3-SNAPSHOT shortly and in 1.2.3 later today.