Skip to content

Commit 2d3894f

Browse files
authored
fix: run flaky upstream tests sequentially (ethereum#15)
* fix: run flaky upstream tests sequentially * chore: run flaky tests first to fail early There are fewer of them so they'll fail quickly and allow the CI run to just be restarted.
1 parent a574ae6 commit 2d3894f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/go.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,7 @@ jobs:
1717
with:
1818
go-version: 1.21.4
1919
- name: Run tests
20-
run: go test -short $(go list ./... | grep -Pv 'go-ethereum/(accounts/keystore|eth/downloader|miner)$')
20+
run: | # Upstream flakes are race conditions exacerbated by concurrent tests
21+
FLAKY_REGEX='go-ethereum/(eth|accounts/keystore|eth/downloader|miner)$';
22+
go list ./... | grep -P "${FLAKY_REGEX}" | xargs -n 1 go test -short;
23+
go test -short $(go list ./... | grep -Pv "${FLAKY_REGEX}");

0 commit comments

Comments
 (0)