Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Service Bus metadata handling in bindings component #1189

Open
CodeMonkeyLeet opened this issue Oct 7, 2021 · 5 comments
Open
Labels
area/runtime/binding good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@CodeMonkeyLeet
Copy link
Contributor

Describe the feature

Per the implementation of #1071 it looks like the Azure Service Bus (ASB) queues bindings component should also be improved to support all ASB message properties. From the code it looks like only MessageID and CorrelationID are explicitly handled on Invoke, and Label is additionally handled on Read.

Release Note

RELEASE NOTE: ADD Comprehensive Azure Service Bus message handling to Azure Service Bus Queues bindings.

@CodeMonkeyLeet CodeMonkeyLeet added kind/enhancement New feature or request area/runtime/binding good first issue Good for newcomers help wanted Extra attention is needed labels Oct 7, 2021
@mukundansundar
Copy link
Contributor

/assign

@berndverst
Copy link
Member

FYI @artursouza

@artursouza artursouza modified the milestones: v1.9, v1.10 Sep 29, 2022
@berndverst
Copy link
Member

@ItalyPaleAle to verify. The share code of all ASB components probably already extracts and sets all ASB properties in Binding Invoke - but if it doesn't that can probably added easily.

@berndverst berndverst modified the milestones: v1.10, v1.11 Feb 1, 2023
@ItalyPaleAle
Copy link
Contributor

It doesn't look like it's happening to the binding:

return func(ctx context.Context, asbMsgs []*servicebus.ReceivedMessage) ([]impl.HandlerResponseItem, error) {

I don't remember why it was done this way, probably to preserve the past behavior. But yes, it shouldn't be hard to add this with the shared code...

@berndverst berndverst modified the milestones: v1.11, v1.12 May 30, 2023
@artursouza artursouza removed this from the v1.12 milestone Jun 30, 2023
@artursouza
Copy link
Member

Needs to validate if this is still not done given the rewrites of the component. /cc @ItalyPaleAle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime/binding good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants