Skip to content

Commit 5cd96ed

Browse files
authored
fix create with 1559 bug (#799)
* fix create with 1559 bug * update changelog
1 parent 59bce78 commit 5cd96ed

File tree

4 files changed

+16
-1
lines changed

4 files changed

+16
-1
lines changed

src/dapp-tests/integration/tests.sh

+4
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@ dapp_testnet() {
5050
# dynamic fee transaction (EIP-1559)
5151
seth send "$A_ADDR" "on()" --gas 0xffff --password /dev/null --from "$ACC" --keystore "$TMPDIR"/8545/keystore --prio-fee 2gwei --gas-price 10gwei
5252

53+
B_ADDR=$(seth send --create 0x647175696e6550383480393834f3 --gas 0xffff --password /dev/null --from "$ACC" --keystore "$TMPDIR"/8545/keystore --prio-fee 2gwei --gas-price 10gwei)
54+
55+
[[ $(seth code "$B_ADDR") = 0x647175696e6550383480393834f3 ]] || error
56+
5357
# clean up
5458
killall geth
5559
}

src/ethsign/CHANGELOG

+6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## Unreleased
8+
9+
### Fixed
10+
11+
Contract creations with Dynamic fee transactions.
12+
713
## [0.17.0] - 2020-02-03
814

915
### Changed

src/ethsign/ethsign.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ func main() {
398398
} else if txtype == types.DynamicFeeTxType {
399399
tx = types.NewTx(&types.DynamicFeeTx{
400400
Nonce: nonce,
401-
To: &common.Address{},
401+
To: nil,
402402
Value: value,
403403
Gas: gasLimit,
404404
GasFeeCap: gasPrice,

src/seth/CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## Unreleased
88

9+
### Fixed
10+
11+
Contract creations with Dynamic fee transactions.
12+
13+
914
### Changed
1015

1116
- `seth 4byte` command returns the response from querying [4byte.directory](https://www.4byte.directory/) for a given function signature

0 commit comments

Comments
 (0)