Update for lint warnings

Author: daohoangson

demo_app/lib/screens/huge_html.dart

@@ -5198,17 +5198,17 @@ class HugeHtmlScreen extends StatelessWidget {
         body: ListView(
           children: [
             ListTile(
-              title: Text('renderMode: Column'),
+              title: const Text('renderMode: Column'),
               onTap: () => Navigator.push(
                   context, MaterialPageRoute(builder: (_) => _ColumnScreen())),
             ),
             ListTile(
-              title: Text('renderMode: ListView'),
+              title: const Text('renderMode: ListView'),
               onTap: () => Navigator.push(context,
                   MaterialPageRoute(builder: (_) => _ListViewScreen())),
             ),
             ListTile(
-              title: Text('renderMode: SliverList'),
+              title: const Text('renderMode: SliverList'),
               onTap: () => Navigator.push(context,
                   MaterialPageRoute(builder: (_) => _SliverListScreen())),
             ),
@@ -5220,12 +5220,12 @@ class HugeHtmlScreen extends StatelessWidget {
 class _ColumnScreen extends StatelessWidget {
   @override
   Widget build(BuildContext context) => Scaffold(
-        appBar: AppBar(title: Text('renderMode: Column')),
+        appBar: AppBar(title: const Text('renderMode: Column')),
         body: SingleChildScrollView(
           child: Padding(
             padding: const EdgeInsets.all(8.0),
             child: RepaintBoundary(
-              child: HtmlWidget(kHtml, renderMode: RenderMode.Column),
+              child: HtmlWidget(kHtml),
             ),
           ),
         ),
@@ -5235,10 +5235,10 @@ class _ColumnScreen extends StatelessWidget {
 class _ListViewScreen extends StatelessWidget {
   @override
   Widget build(BuildContext context) => Scaffold(
-        appBar: AppBar(title: Text('renderMode: ListView')),
+        appBar: AppBar(title: const Text('renderMode: ListView')),
         body: Padding(
           padding: const EdgeInsets.all(8.0),
-          child: HtmlWidget(kHtml, renderMode: RenderMode.ListView),
+          child: HtmlWidget(kHtml, renderMode: RenderMode.listView),
         ),
       );
 }
@@ -5248,15 +5248,15 @@ class _SliverListScreen extends StatelessWidget {
   Widget build(BuildContext context) => Scaffold(
         body: CustomScrollView(
           slivers: [
-            SliverAppBar(
+            const SliverAppBar(
               title: Text('renderMode: SliverList'),
               floating: true,
               expandedHeight: 200,
               flexibleSpace: Placeholder(),
             ),
             SliverPadding(
               padding: const EdgeInsets.all(8.0),
-              sliver: HtmlWidget(kHtml, renderMode: RenderMode.SliverList),
+              sliver: HtmlWidget(kHtml, renderMode: RenderMode.sliverList),
             ),
           ],
         ),

packages/core/lib/src/core_helpers.dart

@@ -101,20 +101,20 @@ enum RenderMode {
   ///
   /// This is the default render mode.
   /// It's good enough for small / medium document and can be used easily.
-  Column,
+  column,
 
   /// The body will be rendered as a `ListView` widget.
   ///
   /// It's good for medium / large document in a dedicated page layout
   /// (e.g. the HTML document is the only thing on the screen).
-  ListView,
+  listView,
 
   /// The body will be rendered as a `SliverList` sliver.
   ///
   /// It's good for large / huge document and can be put in the same scrolling
   /// context with other contents.
   /// A [CustomScrollView] or similar is required for this to work.
-  SliverList,
+  sliverList,
 }
 
 /// An extension on [Widget] to keep track of anchors.

packages/core/lib/src/core_html_widget.dart

@@ -119,7 +119,7 @@ class HtmlWidget extends StatefulWidget {
     this.onTapImage,
     this.onTapUrl,
     RebuildTriggers? rebuildTriggers,
-    this.renderMode = RenderMode.Column,
+    this.renderMode = RenderMode.column,
     this.textStyle = const TextStyle(),
   })  : _rebuildTriggers = rebuildTriggers,
         super(key: key);
@@ -229,10 +229,10 @@ class _HtmlWidgetState extends State<HtmlWidget> {
                 child: CircularProgressIndicator()));
 
     switch (widget.renderMode) {
-      case RenderMode.Column:
-      case RenderMode.ListView:
+      case RenderMode.column:
+      case RenderMode.listView:
         return indicator;
-      case RenderMode.SliverList:
+      case RenderMode.sliverList:
         return SliverToBoxAdapter(child: indicator);
     }
   }

packages/core/lib/src/core_widget_factory.dart

@@ -17,7 +17,7 @@ import 'internal/platform_specific/fallback.dart'
 /// A factory to build widgets.
 class WidgetFactory {
   late AnchorRegistry _anchorRegistry;
-  late final _flattener;
+  late final Flattener _flattener;
 
   BuildOp? _styleBgColor;
   BuildOp? _styleBlock;
@@ -91,7 +91,7 @@ class WidgetFactory {
   /// Builds body widget (see [HtmlWidget.renderMode]).
   Widget buildBodyWidget(BuildContext context, Widget child) {
     var children = child is Column ? child.children : [child];
-    final renderMode = _widget?.renderMode ?? RenderMode.Column;
+    final renderMode = _widget?.renderMode ?? RenderMode.column;
 
     if (children.isNotEmpty && children.first is HeightPlaceholder) {
       children.removeAt(0);
@@ -107,7 +107,7 @@ class WidgetFactory {
         continue;
       }
 
-      if (renderMode != RenderMode.Column && child is CssBlock) {
+      if (renderMode != RenderMode.column && child is CssBlock) {
         final grandChild = child.child;
         if (grandChild is Column) {
           children = grandChild.children;
@@ -119,12 +119,12 @@ class WidgetFactory {
     }
 
     switch (renderMode) {
-      case RenderMode.Column:
+      case RenderMode.column:
         return buildColumnWidget(context, children);
-      case RenderMode.ListView:
+      case RenderMode.listView:
         _anchorRegistry.prepareIndexByAnchor(children);
         return buildBodyListView(context, children);
-      case RenderMode.SliverList:
+      case RenderMode.sliverList:
         _anchorRegistry.prepareIndexByAnchor(children);
         return buildBodySliverList(context, children);
     }
@@ -248,8 +248,10 @@ class WidgetFactory {
     final image = src.image;
     final semanticLabel = image?.alt ?? image?.title;
     return Image(
-      errorBuilder: (_1, _2, _3) => imageErrorBuilder(_1, _2, _3, src),
-      loadingBuilder: (_1, _2, _3) => imageLoadingBuilder(_1, _2, _3, src),
+      errorBuilder: (context, error, stackTrace) =>
+          imageErrorBuilder(context, error, stackTrace, src),
+      loadingBuilder: (context, child, loadingProgress) =>
+          imageLoadingBuilder(context, child, loadingProgress, src),
       excludeFromSemantics: semanticLabel == null,
       fit: BoxFit.fill,
       image: provider,
@@ -271,7 +273,7 @@ class WidgetFactory {
   /// Builder for error widget if an error occurs during image loading.
   Widget imageErrorBuilder(
     BuildContext context,
-    Object error,
+    dynamic error,
     StackTrace? stackTrace,
     ImageSource src,
   ) {
@@ -289,7 +291,6 @@ class WidgetFactory {
     return text.isNotEmpty
         ? RichText(
             maxLines: 1,
-            overflow: TextOverflow.clip,
             softWrap: false,
             text: TextSpan(style: style, text: text),
             textDirection: tsh.textDirection,

packages/core/lib/src/internal/ops/anchor.dart

@@ -76,7 +76,6 @@ class AnchorRegistry {
     if (anchorMin < effectiveMin) {
       movedOk = await _ensureVisibleContext(
         _bodyItemKeys[currentMin].currentContext,
-        alignment: 0.0,
         curve: jumpCurve,
         duration: jumpDuration,
       );

packages/core/lib/src/widgets/html_list_marker.dart

@@ -50,6 +50,7 @@ class _ListMarkerRenderObject extends RenderBox {
   _ListMarkerRenderObject(this._markerType, this._textStyle);
 
   HtmlListMarkerType _markerType;
+  // ignore: avoid_setters_without_getters
   set markerType(HtmlListMarkerType v) {
     if (v == _markerType) return;
     _markerType = v;
@@ -65,6 +66,7 @@ class _ListMarkerRenderObject extends RenderBox {
   }
 
   TextStyle _textStyle;
+  // ignore: avoid_setters_without_getters
   set textStyle(TextStyle v) {
     if (v == _textStyle) return;
     __textPainter = null;
@@ -87,8 +89,9 @@ class _ListMarkerRenderObject extends RenderBox {
     var lineMetrics = <LineMetrics>[];
     try {
       lineMetrics = _textPainter.computeLineMetrics();
-      // ignore: empty_catches
-    } on UnimplementedError {}
+    } catch (e) {
+      debugPrint('computeLineMetrics error: $e');
+    }
 
     final m = lineMetrics.isNotEmpty ? lineMetrics.first : null;
     final center = offset +

packages/core/test/anchor_test.dart

@@ -51,7 +51,7 @@ Future<void> main() async {
         hw: HtmlWidget(
           html,
           key: hwKey,
-          renderMode: RenderMode.ListView,
+          renderMode: RenderMode.listView,
         ),
         useExplainer: false,
       );
@@ -68,7 +68,7 @@ Future<void> main() async {
           HtmlWidget(
             html,
             key: hwKey,
-            renderMode: RenderMode.SliverList,
+            renderMode: RenderMode.sliverList,
           )
         ]),
         useExplainer: false,
@@ -389,7 +389,7 @@ class _ListViewTestApp extends StatelessWidget {
         body: HtmlWidget(
           html ?? htmlDefault,
           factoryBuilder: () => _WidgetFactory(),
-          renderMode: RenderMode.ListView,
+          renderMode: RenderMode.listView,
         ),
       );
 }
@@ -408,7 +408,7 @@ class _SliverListTestApp extends StatelessWidget {
             HtmlWidget(
               html ?? htmlDefault,
               factoryBuilder: () => _WidgetFactory(),
-              renderMode: RenderMode.SliverList,
+              renderMode: RenderMode.sliverList,
             ),
             SliverToBoxAdapter(child: Container(height: 1, key: keyBottom)),
           ],

packages/core/test/core_config_test.dart

@@ -464,7 +464,7 @@ void main() {
   });
 
   group('renderMode', () {
-    final explain = (
+    Future<String> explain(
       WidgetTester tester,
       RenderMode renderMode, {
       bool buildAsync = false,
@@ -480,39 +480,39 @@ void main() {
       return helper.explain(
         tester,
         null,
-        hw: renderMode == RenderMode.SliverList
+        hw: renderMode == RenderMode.sliverList
             ? CustomScrollView(slivers: [hw])
             : hw,
         useExplainer: false,
       );
-    };
+    }
 
     testWidgets('renders Column', (WidgetTester tester) async {
-      final explained = await explain(tester, RenderMode.Column);
+      final explained = await explain(tester, RenderMode.column);
       expect(explained, contains('└Column('));
     });
 
     testWidgets('renders ListView', (WidgetTester tester) async {
-      final explained = await explain(tester, RenderMode.ListView);
+      final explained = await explain(tester, RenderMode.listView);
       expect(explained, contains('└ListView('));
       expect(explained, isNot(contains('└Column(')));
     });
 
     testWidgets('renders SliverList', (WidgetTester tester) async {
-      final explained = await explain(tester, RenderMode.SliverList);
+      final explained = await explain(tester, RenderMode.sliverList);
       expect(explained, contains('└SliverList('));
       expect(explained, isNot(contains('└Column(')));
     });
 
     testWidgets('renders SliverList (buildAsync)', (WidgetTester tester) async {
-      final e = await explain(tester, RenderMode.SliverList, buildAsync: true);
+      final e = await explain(tester, RenderMode.sliverList, buildAsync: true);
       expect(e, contains('└SliverToBoxAdapter('));
     });
 
     testWidgets('renders SliverList (CssBlock unwrap)', (tester) async {
       final explained = await explain(
         tester,
-        RenderMode.SliverList,
+        RenderMode.sliverList,
         html: '<div><p>Foo</p><p>Bar</p></div>',
       );
       expect(explained.split('└CssBlock(').length, equals(3),

packages/core/test/tag_li_test.dart

@@ -603,7 +603,7 @@ Future<void> main() async {
     });
 
     testWidgets('null buildListMarker', (WidgetTester tester) async {
-      final html = '<ul><li>Foo</li></ul>';
+      const html = '<ul><li>Foo</li></ul>';
       final explained = await explain(tester, null,
           hw: HtmlWidget(
             html,

packages/enhanced/lib/src/html_widget.dart

@@ -51,7 +51,7 @@ class HtmlWidget extends core.HtmlWidget {
     void Function(ImageMetadata)? onTapImage,
     dynamic Function(String)? onTapUrl,
     core.RebuildTriggers? rebuildTriggers,
-    RenderMode renderMode = RenderMode.Column,
+    RenderMode renderMode = RenderMode.column,
     TextStyle textStyle = const TextStyle(),
     this.webView = false,
     this.webViewDebuggingEnabled = false,