Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Chapter 4 (scanner) #3

Merged
merged 12 commits into from
Jan 9, 2024
Merged

feat: Implement Chapter 4 (scanner) #3

merged 12 commits into from
Jan 9, 2024

Conversation

danvk
Copy link
Owner

@danvk danvk commented Jan 9, 2024

PR Checklist

Overview

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@14498fe). Click here to learn what that means.

❗ Current head 8ba6f58 differs from pull request most recent head 17f458c. Consider uploading reports for the commit 17f458c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   74.92%           
=======================================
  Files           ?        5           
  Lines           ?      331           
  Branches        ?       39           
=======================================
  Hits            ?      248           
  Misses          ?       82           
  Partials        ?        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danvk danvk changed the title Implement Chapter 4 (scanner) Feat: Implement Chapter 4 (scanner) Jan 9, 2024
@danvk danvk changed the title Feat: Implement Chapter 4 (scanner) feat: Implement Chapter 4 (scanner) Jan 9, 2024
.eslintrc.cjs Outdated Show resolved Hide resolved
@danvk danvk merged commit e2493bc into main Jan 9, 2024
11 checks passed
@danvk danvk deleted the chapter4 branch January 9, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants