fixed #13909 / refs #13914 - some (enforced) language handling fixes for the GUI #7570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
force-pushed
the
import-gui
branch
10 times, most recently
from
f85cc26 to
2b9d467
Compare
This comment was marked as resolved.
This comment was marked as resolved.
firewave
changed the title
firewave
changed the title
firewave
changed the title
firewave
commented
Jun 15, 2025
| namespace frontend | ||
| {} | ||
| { | ||
| void applyLang(std::list<FileSettings> &fileSettings, const Settings &settings, Standards::Language enforcedLang); |
There was a problem hiding this comment.
Still needs documentation - and unit test.
|
This makes me wonder if markup files are handled properly in the GUI. But not something to explicitly look into as it should be implicitly be fixed as we move towards the shared executor code. |
|
Requires #7598 to be merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.