Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS Review] Include dependencies in installation #38

Open
stella-bourdin opened this issue Oct 18, 2024 · 1 comment
Open

[JOSS Review] Include dependencies in installation #38

stella-bourdin opened this issue Oct 18, 2024 · 1 comment

Comments

@stella-bourdin
Copy link

Hello,
This issue arises from the JOSS review ongoing here: openjournals/joss-reviews#7363
The installation of the package goes well, but the dependencies are not automatically installed. Can you include it in the installation?

@daniloceano
Copy link
Owner

Hi @stella-bourdin,

Thank you for your feedback! I’ve updated the setup.py to ensure that all dependencies are included in the install_requires section. This way, when you install the package via pip install cyclophaser, all the necessary dependencies should now be installed automatically.

Please let me know if you encounter any further issues, and feel free to test it out!

Best regards,
Danilo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants