Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split PaginatedResults into 2 classes, one sync and one async #96

Open
rgeronimi opened this issue Oct 24, 2024 · 0 comments
Open

Split PaginatedResults into 2 classes, one sync and one async #96

rgeronimi opened this issue Oct 24, 2024 · 0 comments
Labels

Comments

@rgeronimi
Copy link
Contributor

rgeronimi commented Oct 24, 2024

Ths is follows #95 where we patchd PaginatedResults to be 100% async. Its resulting code is a bit convoluted, as it mixes sync and async APIs, whereas other library classes (e.g., SemanticScholarcleanly separate the sync and async versions).

PS : for the future I think the PaginatedResults class could be split in 2 sync vs async versions. This would make the API and code much clearer than it is today, exactly like the SemanticScholar class.

It might be worth opening an issue or PR to discuss this further.

Originally posted by @danielnsilva in #95 (comment)

@rgeronimi rgeronimi changed the title Split the PaginatedResults into 2 classes, one sync and one async Split PaginatedResults into 2 classes, one sync and one async Oct 24, 2024
@github-actions github-actions bot added the Stale label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant