From 475be6c25c01949f8f2a2703f8f5f8128a48a66b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 2 Feb 2022 22:35:51 -0800 Subject: [PATCH] tools: enable no-empty ESLint rule MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refs: https://eslint.org/docs/rules/no-empty PR-URL: https://github.com/nodejs/node/pull/41831 Backport-PR-URL: https://github.com/nodejs/node/pull/42160 Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel --- .eslintrc.js | 1 - benchmark/.eslintrc.yaml | 1 - test/.eslintrc.yaml | 1 - 3 files changed, 3 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 8e6a2f99aeb065..7c939124ee267e 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -295,7 +295,6 @@ module.exports = { 'valid-typeof': ['error', { requireStringLiterals: true }], // ESLint recommended rules that we disable - 'no-empty': 'off', 'no-inner-declarations': 'off', // JSDoc recommended rules that we disable diff --git a/benchmark/.eslintrc.yaml b/benchmark/.eslintrc.yaml index d7c59654fbe46d..6871299adece7b 100644 --- a/benchmark/.eslintrc.yaml +++ b/benchmark/.eslintrc.yaml @@ -5,6 +5,5 @@ env: es6: true rules: - no-empty: error no-var: error prefer-arrow-callback: error diff --git a/test/.eslintrc.yaml b/test/.eslintrc.yaml index d9a0e3d3c5f587..67a2b9667bb583 100644 --- a/test/.eslintrc.yaml +++ b/test/.eslintrc.yaml @@ -6,7 +6,6 @@ env: rules: multiline-comment-style: ["error", "separate-lines"] - no-empty: error no-var: error prefer-const: error symbol-description: off