Skip to content

Commit

Permalink
test: remove lint rule for setTimeout() arguments
Browse files Browse the repository at this point in the history
With the introduction of the promises API for setTimeout(), the
requirement that it have two parameters may not be sensible anymore in
tests.

PR-URL: nodejs#41901
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and danielleadams committed Apr 21, 2022
1 parent 914f907 commit 11e76fc
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
2 changes: 0 additions & 2 deletions test/.eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ rules:
message: "Use an object as second argument of `assert.throws()`."
- selector: "CallExpression:matches([callee.name='throws'], [callee.property.name='throws'])[arguments.length<2]"
message: "`assert.throws()` must be invoked with at least two arguments."
- selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]"
message: "`setTimeout()` must be invoked with at least two arguments."
- selector: "CallExpression[callee.name='setInterval'][arguments.length<2]"
message: "`setInterval()` must be invoked with at least two arguments."
- selector: "ThrowStatement > CallExpression[callee.name=/Error$/]"
Expand Down
7 changes: 0 additions & 7 deletions test/parallel/test-stream-construct-async-error.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const assert = require('assert');
{
class Foo extends Duplex {
async _destroy(err, cb) {
// eslint-disable-next-line no-restricted-syntax
await setTimeout(common.platformTimeout(1));
throw new Error('boom');
}
Expand All @@ -31,7 +30,6 @@ const assert = require('assert');
{
class Foo extends Duplex {
async _destroy(err, cb) {
// eslint-disable-next-line no-restricted-syntax
await setTimeout(common.platformTimeout(1));
}
}
Expand All @@ -46,7 +44,6 @@ const assert = require('assert');
{
class Foo extends Duplex {
async _construct() {
// eslint-disable-next-line no-restricted-syntax
await setTimeout(common.platformTimeout(1));
}

Expand All @@ -64,7 +61,6 @@ const assert = require('assert');
{
class Foo extends Duplex {
async _construct(callback) {
// eslint-disable-next-line no-restricted-syntax
await setTimeout(common.platformTimeout(1));
callback();
}
Expand All @@ -88,7 +84,6 @@ const assert = require('assert');
});

async _final() {
// eslint-disable-next-line no-restricted-syntax
await setTimeout(common.platformTimeout(1));
}
}
Expand All @@ -105,7 +100,6 @@ const assert = require('assert');
});

async _final(callback) {
// eslint-disable-next-line no-restricted-syntax
await setTimeout(common.platformTimeout(1));
callback();
}
Expand All @@ -123,7 +117,6 @@ const assert = require('assert');
});

async _final() {
// eslint-disable-next-line no-restricted-syntax
await setTimeout(common.platformTimeout(1));
throw new Error('boom');
}
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-stream-writable-final-async.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const { setTimeout } = require('timers/promises');
{
class Foo extends Duplex {
async _final(callback) {
// eslint-disable-next-line no-restricted-syntax
await setTimeout(common.platformTimeout(1));
callback();
}
Expand Down

0 comments on commit 11e76fc

Please sign in to comment.