Fix pydict serialization for optional fields #495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a block in
Mesaage.to_pydict
that explicitly checks forNone
values and assigns them to the dict ifinclude_default_values=True
.Why
Fixes #475 where
to_pydict
fails on optional fields with the error:Testing
Added a test case that checks
to_pydict
andto_dict
output when passing the message value and not, and when passinginclude_default_values
and not.