Added support for @generated marker #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonín Říha <riha.antonin@outlook.com>
|
I think sticking to the same format as protoc might be a good idea, the |
Gobot1234
previously approved these changes
May 17, 2022
Signed-off-by: Antonín Říha <antonin.riha@protonmail.com>
|
Yes you are probably right, it seems that it just has to be somewhere at the beginning (not clearly defined). But from examples I found it seems that it can be below. |
Gobot1234
previously approved these changes
May 17, 2022
|
One more idea would be to regenerate the pre-compiled files in lib/google/protobuf |
Signed-off-by: Antonín Říha <antonin.riha@protonmail.com>
|
I regenerated all the lib/google/protobuf files. Looking at the output it seems like the generated files had wrong documentation for attributes (before attribute definition, not after). So this also fixes that. |
|
Thanks, this looks great |
Gobot1234
approved these changes
Aug 2, 2022
Gobot1234
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for @generated marker as specified at https://generated.at/ This marks generated code as such and allows it to be skipped in CI/CD. I am just not sure if this is the right format or if adding it after current message would be better.