Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop overwriting __init__.pys #337

Merged
merged 9 commits into from
Apr 23, 2022
Merged

Stop overwriting __init__.pys #337

merged 9 commits into from
Apr 23, 2022

Conversation

Gobot1234
Copy link
Collaborator

@Gobot1234 Gobot1234 commented Feb 15, 2022

Fixes #260
Fixes #168
@nat-n mentioned in #168 that there could be "a legit use case if content has been removed from the proto since the previous version." but I don't think that matters cause v2 can have breaking changes

cetanu
cetanu previously approved these changes Feb 15, 2022
@Gobot1234 Gobot1234 mentioned this pull request Mar 4, 2022
3 tasks
@Gobot1234 Gobot1234 requested a review from cetanu April 13, 2022 17:17
@Gobot1234 Gobot1234 changed the title Stop overwritting __init__.pys Stop overwriting __init__.pys Apr 20, 2022
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
@abn abn merged commit 6a70b8e into danielgtaylor:master Apr 23, 2022
@Gobot1234 Gobot1234 deleted the fix-260 branch April 24, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generating python should not override __init__.py files Package __init__ files overwritten at compile
3 participants