test: check if empty dependentRequired is ignored

danielgtaylor · Mar 13, 2024 · c8be1f9 · c8be1f9
1 parent 64fddff
commit c8be1f9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/schema_test.go b/schema_test.go
@@ -443,6 +443,7 @@ func TestSchema(t *testing.T) {
 			input: struct {
 				Value     string `json:"value,omitempty" dependentRequired:"dependent"`
 				Dependent string `json:"dependent,omitempty"`
+				Ignored   string `json:"ignored,omitempty" dependentRequired:""`
 			}{},
 			expected: `{
 				"type": "object",
@@ -452,6 +453,9 @@ func TestSchema(t *testing.T) {
 					},
 					"dependent": {
 						"type": "string"
+					},
+					"ignored": {
+						"type": "string"
 					}
 				},
 				"dependentRequired": {

diff --git a/validate_test.go b/validate_test.go
@@ -1019,7 +1019,7 @@ var validateTests = []struct {
 		errs:  []string{"expected length >= 1"},
 	},
 	{
-		name: "dependentRequired empty success ",
+		name: "dependentRequired empty success",
 		typ: reflect.TypeOf(struct {
 			Value     string `json:"value,omitempty" dependentRequired:"dependent"`
 			Dependent string `json:"dependent,omitempty"`
@@ -1036,6 +1036,15 @@ var validateTests = []struct {
 		input: map[string]any{"value": "abc", "dependent": "123"},
 		errs:  nil,
 	},
+	{
+		name: "dependentRequired ignored success",
+		typ: reflect.TypeOf(struct {
+			Value     string `json:"value,omitempty" dependentRequired:""`
+			Dependent string `json:"dependent,omitempty"`
+		}{}),
+		input: map[string]any{},
+		errs:  nil,
+	},
 	{
 		name: "dependentRequired failure",
 		typ: reflect.TypeOf(struct {