chore(sample): Improve WebApiSample, adding SwaggerUI, fix invalid cast from JObject #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cast JObject on publish event will not work with different workflow data type. |
|
As this is a sample, I'd prefer to keep it simple, it does not need to work for all sorts of types... just illustrate how it works. |
|
Sorry for late reply. Yes, for simplicity, I've moved the cast to EventController. I've also added Swagger for easy debugging WebApiSample. Please have a look. Thank you. |
hieuxlu
changed the title
danielgerlag
approved these changes
May 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventsController in WebApiSample is receiving event data as JObject, but TestWorkFlow is trying to cast data to string. This would probably cause headache when first opening the WebApiSample.