Minor inconsistency issue with dataset serialize/deserialize

[veex-ua]

DataSet.Utils.AsJSONArray method calls TMVCJsonDataObjectsSerializer.SerializeDataSet method with hard-coded ncLowerCase parameter.

delphimvcframework/sources/MVCFramework.DataSet.Utils.pas

Line 127 in f64eebf

Result := lSerializer.SerializeDataSet(Self, [], ncLowerCase);

Serializer.JsonDataObjects.TMVCJsonDataObjectsSerializer.DeserializeDataSet method, by default, will not lower case target datasets' field names (ncAsIs).

delphimvcframework/sources/MVCFramework.Serializer.JsonDataObjects.pas

Lines 97 to 98 in f64eebf

	procedure DeserializeDataSet(const ASerializedDataSet: string; const ADataSet: TDataSet;
	const AIgnoredFields: TMVCIgnoredList = []; const ANameCase: TMVCNameCase = ncAsIs);

As a result, field names in serialized dataset string (which are lower cased due to ncLowerCase) are matched against target datasets' field names (which are not guaranteed to be lower cased due to ncAsIs). We have to explicitly specify ncLowerCase as last parameter of DeserializeDataSet method, otherwise deserialization might produce wrong result (only empty records are created).

If DataSet.Utils.AsJSONArray method used ncAsIs instead of ncLowerCase we wouldn't have to explicitly specify ANameCase argument when calling DeserializeDataSet. This would also be consistent with how AsJSONObject <> DeserializeDataSetRecord is functioning right now (both methods use ncAsIs).

The issue is pretty minor and this change might break existing code bases. It might be a good idea to include this tweak in 3.1 and mention it in breaking changes list. Happy Holidays 🎅