Skip to content

Rename types.isClosure #39

Open
Open
@daniele-rapagnani

Description

@daniele-rapagnani

It's probably best to rename types.isClosure to types.isFunction. Even if they are called Closures by the VM they are Functions for the end-user.

Activity

Siddharth1010

Siddharth1010 commented on Jan 7, 2021

@Siddharth1010

@daniele-rapagnani In which file does the issue lie?

daniele-rapagnani

daniele-rapagnani commented on Jan 7, 2021

@daniele-rapagnani
OwnerAuthor

Hey @Siddharth1010 , you can find it in types_module.c. It should be as simple as renaming it there and possibly in some of the unit tests, I suspect only in the ones pertaining to the types module itself.

NathanGugel

NathanGugel commented on Jan 12, 2021

@NathanGugel
Contributor

Hey @Siddharth1010! I was wondering if you still wanted to fix this issue? I'm working on another issue related to the types module, so I wanted to check. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @daniele-rapagnani@NathanGugel@Siddharth1010

      Issue actions

        Rename types.isClosure · Issue #39 · daniele-rapagnani/melon