Run websocket server on same port as other HTTP serving

[khimaros]

This is currently blocked on upstream Rocket feature which has seen some recent progress: rwf2/Rocket#90

[BlackDex]

I Think this is going to take a while when reading that ticket.
Luckily we can use reverse proxies to solve this shortcoming for now.

[BlackDex]

Going to close this as an issue.
I have added it to the META Features request #246 .

[fidelix]

BTW, this is now possible and is available upstream.

[BlackDex]

See #3404

[binaryben]

Neat, came to the say the same and it's already done! Would anyone be kind enough please to let me know what changes need to be made when using Caddy as a reverse proxy? Second question - the current config seems to still work, so is there going to be both options for getting websockets to work?

[BlackDex]

@binaryben basically remove the reverse_proxy /notifications/hub <SERVER>:3012 line should do it.
You can also set WEBSOCKET_ENABLED to false, which prevents a separate thread from being started.

[binaryben]

Thanks @BlackDex. Is that in the current vaultwarden/server:latest docker image? I'll try it and report back once my Postgres service is back online if it is 😬

[BlackDex]

You need to use :testing for this to work.