Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update web-vault to v2024.5.0 #160

Merged
merged 3 commits into from
May 18, 2024

Conversation

stefan0xC
Copy link
Contributor

New web-vault release: web-v2024.4.1

Note

I've skipped v2024.4.0 because it only removed the banner informing users about the layout change. The banner was replaced by one that shows a message if there are unassigned messages (bitwarden/clients#8655). But for that to work we'd need to provide the /api/ciphers/has-unassigned-ciphers endpoint (bitwarden/server#3967) in vaultwarden. (This feature is currently behind the UnassignedItemsBanner flag.)

@BlackDex
Copy link
Collaborator

Ah nice, lets test it out.
We also might want to update the meta features request on the other repo to maybe add some of these feature flags and maybe create discussions in the Idea section for these kind of features, same as for flexible collections.

That way we have somewhere to track missing features and also can note if someone starts working on it.

@BlackDex
Copy link
Collaborator

BlackDex commented May 3, 2024

@stefan0xC i totally forgot this one, sorry.
Maybe best to update to v2024.4.2 then?

@BlackDex
Copy link
Collaborator

BlackDex commented May 3, 2024

Seems there is a DUO issues with that version.
Not sure if that is also the case for this version, but it will hinder my tests to migrate to the new DUO way of login.

bitwarden/clients#8554

@stefan0xC stefan0xC changed the title update web-vault to v2024.4.1 update web-vault to v2024.4.2 May 3, 2024
@stefan0xC
Copy link
Contributor Author

I have not really looked at this release yet. Just noticed an issue with getting billing metadata (which we have not implemented), so I've set it to false here:

- const billingMetadata = await this.billingApiService.getOrganizationBillingMetadata(
- this.organization.id,
- );
-
- this.orgIsOnSecretsManagerStandalone = billingMetadata.isOnSecretsManagerStandalone;
+ this.orgIsOnSecretsManagerStandalone = false; // don't get billing metadata

@BlackDex
Copy link
Collaborator

Uch, on v2024.5.0 now haha.
I really need to find some time to do some testing and release this

@stefan0xC stefan0xC changed the title update web-vault to v2024.4.2 update web-vault to v2024.5.0 May 14, 2024
@stefan0xC
Copy link
Contributor Author

I've updated the web-vault to the newest release. Regarding testing I think that we might want to add playwright tests to this repo but we should maybe discuss it in this thread: dani-garcia/vaultwarden#4369 (comment)?

@BlackDex
Copy link
Collaborator

I've updated the web-vault to the newest release. Regarding testing I think that we might want to add playwright tests to this repo but we should maybe discuss it in this thread: dani-garcia/vaultwarden#4369 (comment)?

Yea, that would be useful indeed.

@BlackDex BlackDex merged commit cc03d26 into dani-garcia:master May 18, 2024
@BlackDex
Copy link
Collaborator

Thanks @stefan0xC, I implemented this web-vault in my latest PR to update the crates and Rust :).

@stefan0xC stefan0xC deleted the update-to-v2024.4 branch May 18, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants