Skip to content

Commit 0df0be3

Browse files
authored
Merge pull request #13 from albertored/fix-specs
fixed typespecs
2 parents 35ea005 + f8ac001 commit 0df0be3

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

lib/temp.ex

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ defmodule Temp do
3030
@doc """
3131
Same as `track/1`, but raises an exception on failure. Otherwise, returns `:ok`
3232
"""
33-
@spec track! :: pid
33+
@spec track! :: pid | no_return
3434
def track!() do
3535
case track() do
3636
{:ok, pid} -> pid
37-
err -> raise Temp.Error, message: err
37+
{:error, err} -> raise Temp.Error, message: err
3838
end
3939
end
4040

@@ -84,7 +84,7 @@ defmodule Temp do
8484
def path!(options \\ nil) do
8585
case path(options) do
8686
{:ok, path} -> path
87-
err -> raise Temp.Error, message: err
87+
{:error, err} -> raise Temp.Error, message: err
8888
end
8989
end
9090

@@ -99,7 +99,7 @@ defmodule Temp do
9999
100100
See `path/1`.
101101
"""
102-
@spec open(options, nil | (File.io_device -> any)) :: {:ok, File.io_device, Path.t} | {:error, any}
102+
@spec open(options, nil | (File.io_device -> any)) :: {:ok, Path.t} | {:ok, File.io_device, Path.t} | {:error, any}
103103
def open(options \\ nil, func \\ nil) do
104104
case generate_name(options, "f") do
105105
{:ok, path, options} ->
@@ -122,7 +122,7 @@ defmodule Temp do
122122
@doc """
123123
Same as `open/1`, but raises an exception on failure.
124124
"""
125-
@spec open!(options, pid | nil) :: {File.io_device, Path.t}
125+
@spec open!(options, pid | nil) :: Path.t | {File.io_device, Path.t} | no_return
126126
def open!(options \\ nil, func \\ nil) do
127127
case open(options, func) do
128128
{:ok, res, path} -> {res, path}
@@ -159,7 +159,7 @@ defmodule Temp do
159159
Same as `mkdir/1`, but raises an exception on failure. Otherwise, returns
160160
a temporary directory path.
161161
"""
162-
@spec mkdir!(options) :: Path.t
162+
@spec mkdir!(options) :: Path.t | no_return
163163
def mkdir!(options \\ %{}) do
164164
case mkdir(options) do
165165
{:ok, path} ->
@@ -192,14 +192,11 @@ defmodule Temp do
192192
end
193193
end
194194

195-
196-
@spec add_suffix([String.t], nil | String.t) :: [String.t]
197195
defp add_suffix(parts, suffix)
198196
defp add_suffix(parts, nil), do: parts
199197
defp add_suffix(parts, ("." <> _suffix) = suffix), do: parts ++ [suffix]
200198
defp add_suffix(parts, suffix), do: parts ++ ["-", suffix]
201199

202-
@spec prefix(nil | map) :: {:ok, Path.t} | {:error, String.t}
203200
defp prefix(%{basedir: dir}), do: {:ok, dir}
204201
defp prefix(_) do
205202
case System.tmp_dir do
@@ -208,7 +205,6 @@ defmodule Temp do
208205
end
209206
end
210207

211-
@spec parse_affixes(options, Path.t) :: map
212208
defp parse_affixes(nil, default_prefix), do: %{prefix: default_prefix}
213209
defp parse_affixes(affixes, _) when is_bitstring(affixes), do: %{prefix: affixes, suffix: nil}
214210
defp parse_affixes(affixes, default_prefix) when is_map(affixes) do

0 commit comments

Comments
 (0)