Add title to Field calls where necessary

[jjnesbitt]

This is something I've noticed for a while now, and figured I'd just add these titles. Almost all of the titles are just the variable name with capitalization and spaces, so I doubt there's much wrong here, but if there is please lmk.

[codecov]

Codecov Report

Merging #299 (bea4699) into master (511143d) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
- Coverage   81.88%   81.80%   -0.09%     
==========================================
  Files          54       54              
  Lines        4886     4886              
==========================================
- Hits         4001     3997       -4     
- Misses        885      889       +4     

Flag	Coverage Δ
unittests	81.80% <100.00%> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dandi/models.py	81.25% <100.00%> (ø)
dandi/tests/test_models.py	100.00% <100.00%> (ø)
dandi/cli/cmd_organize.py	77.30% <0.00%> (-2.46%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 511143d...bea4699. Read the comment docs.

[yarikoptic]

although "explicit better than implicit" I generally prefer to avoid duplication.
I wonder why just not at the level of UI to apply the rule of having camelCased to become Camel Cased and apply rules to downcase of, to etc if encountered upon splitting?

[yarikoptic]

FWIW, might be better to have that "code" to be actually here within schema conversion tools, so produced .json would already have titles. That would centralize the code and not offload it upon UIs.

[satra]

@AlmightyYakob - i sent some changes on top of yours (feel free to merge that). i was mostly focusing on the non-autogenerated ones. the reason license was misbehaving is that pydantic does not generate titles automatically for fields that have a type that's an enum. (i don't know why). so i fixed titles for all of them.

[jjnesbitt]

FWIW, might be better to have that "code" to be actually here within schema conversion tools, so produced .json would already have titles. That would centralize the code and not offload it upon UIs.

I agree, as otherwise it's more code that splits the schema used in the UI from the source schema. I realize that title formatting is a pretty small change, but JSON Schema is designed to be able to specify this information, without intervention from whatever is displaying it.

[yarikoptic]

FWIW, might be better to have that "code" to be actually here within schema conversion tools, so produced .json would already have titles. That would centralize the code and not offload it upon UIs.

I agree, as otherwise it's more code that splits the schema used in the UI from the source schema. I realize that title formatting is a pretty small change, but JSON Schema is designed to be able to specify this information, without intervention from whatever is displaying it.

ok, filed #301 so could be done after to not hold this PR hostage

[jwodder]

I've submitted a PR on the head repository to fix the failing tests: jjnesbitt#3

[yarikoptic]

well, don't we need PRs to come from branches in this repository to get access to some secrets? then this PR should be redone from a branch here anyways. @jwodder , please just submit a new PR from a branch here to supersede this PR. @AlmightyYakob is also part of the team , so he should be able to push directly to that branch if would be needed

[jwodder]

@yarikoptic Are you sure superseding this PR is necessary? The only secret the test workflow relies on is for pushing to Codecov.

[yarikoptic]

we can wait for all the dance with merging of a PR for a PR to happen and then ignore codecov, or could just streamline with superseded PR with all the commits desired to bring it to the finish line together. up to you ;)

[jjnesbitt]

@AlmightyYakob is also part of the team , so he should be able to push directly to that branch if would be needed

Do I have contributor access on this repo? If so, then in the future I'm happy to deal with branches here directly.

[yarikoptic]

@AlmightyYakob is also part of the team , so he should be able to push directly to that branch if would be needed

Do I have contributor access on this repo? If so, then in the future I'm happy to deal with branches here directly.

AFAIK yes, you are part of the dandi-cli team https://github.com/orgs/dandi/teams/dandi-cli/members

[yarikoptic]

ok, since @satra did not raise any concerns, I guess it is good to go!