Add emscripten support

[malbarbo]

No description provided.

[malbarbo]

Tests fails using node, it seems that libc is broken for emscripten, but posix_fallocate is available on emsdk musl.

I'm working in improving the emscripen support in the rust ecosystem, could you please release a new dot release?

[malbarbo]

PR to enable and fixes tests for libc on emscripten.

[danburkert]

I'm not quite following, is this ready to merge?

[malbarbo]

I though before that this was ready to merge, but now I think we should wait until we can test this. After libc PR got merged, I will send a PR to update libc on rust, then we can run the tests and make sure it works.

[danburkert]

SGTM, thanks.

[lilianmoraru]

The new libc is getting merged upstream: rust-lang/rust#44116

[danburkert]

Is there any way to add emscripten coverage to travis?

[lilianmoraru]

@danburkert libc 0.2.30 was merged in the nightly Rust.
With this fix, we could try to test on nightly(binaries through rust-buildbot probably not available yet).
I still think that a new version should not be published until Travis is set to test the target.

[danburkert]

Yah I agree, it would be nice to have emscripten coverage in CI if feasible. However, If it would require jumping through a bunch of hoops, I could be convinced to go ahead since this is such a minimal change.

[danburkert]

Is this still a concern with all of the recent WASM stuff landing in Rust? I admit I haven't been following that as closely as I might, since I don't target browsers.

[lilianmoraru]

Well, packages that depend on fs2 will still not be able to compile because of that missing cfg.

[danburkert]

@lilianmoraru has anything changed WRT feasibility of testing with travis?

[lilianmoraru]

@danburkert

• cargo web test
• wargo test

[danburkert]

OK sounds good, let's leave this open then. I'm not personally going to have time to drive it forward, but I welcome others to.

Thanks @lilianmoraru !

[lilianmoraru]

All the blockers have been closed(maybe a libc update would be good).
What do you think about getting this in and then somebody could work on the CI?

[danburkert]

Yeah I'm fine with that. The libc version is floating (^), so I don't think it should cause problems. I'll go ahead and merge.