Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self Service's custom icon not displaying as overlayicon when SYM is executed via an enrollmentComplete trigger #40

Closed
dan-snelson opened this issue Feb 24, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@dan-snelson
Copy link
Owner

See swiftDialog Issue No. 235.

Describe the bug

  • When Setup Your Mac is executed via an enrollmentComplete trigger, Self Service's icon is not displaying as expected.
  • See this thread and
  • This thread

To Reproduce

  • Execute SYM via an enrollmentComplete trigger

Expected behavior

  • Self Service's custom icon displays as overlayicon

Code/log output

su - "${loggedInUser}" -c "/usr/bin/open -a \"${overlayicon}\" -g -j"
@dan-snelson dan-snelson added the bug Something isn't working label Feb 24, 2023
@dan-snelson dan-snelson self-assigned this Feb 24, 2023
@dan-snelson
Copy link
Owner Author

Thanks, @GadgetGeekNI (and @mactroll)

# If SELF_SERVICE_CUSTOM_BRANDING is set to true. Loading the updated icon
  if [ "$SELF_SERVICE_CUSTOM_BRANDING" = true ]; then
    open -a "/Applications/$SELF_SERVICE_APP_NAME" --hide

    # Loop waiting on the branding image to properly show in the users library - wait up to 20 seconds
     SELF_SERVICE_COUNTER=0
     CUSTOM_BRANDING_PNG="/Users/$CURRENT_USER/Library/Application Support/com.jamfsoftware.selfservice.mac/Documents/Images/brandingimage.png"

     until [ -f "$CUSTOM_BRANDING_PNG" ]; do
       echo "$(date "+%a %h %d %H:%M:%S"): Waiting for branding image from Jamf Pro." >> "$DEP_NOTIFY_DEBUG"
        sleep 1
        (( SELF_SERVICE_COUNTER++ ))
        if [ $SELF_SERVICE_COUNTER -gt $SELF_SERVICE_CUSTOM_WAIT ];then
            CUSTOM_BRANDING_PNG="/Applications/Self Service.app/Contents/Resources/AppIcon.icns"
            break
        fi
     done

@dan-snelson
Copy link
Owner Author

Addressed in 1.7.2-rc2.

@dan-snelson
Copy link
Owner Author

Addressed in 1.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant