Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup your Mac: Wait for dialog to close before exiting #4

Closed
pyther opened this issue Aug 24, 2022 · 4 comments
Closed

Setup your Mac: Wait for dialog to close before exiting #4

pyther opened this issue Aug 24, 2022 · 4 comments
Assignees
@dan-snelson
Labels
enhancement New feature or request

Comments

@pyther
Copy link

pyther commented Aug 24, 2022

When running the Setup your Mac.bash script from a Jamf policy, the dialog window will automatically close once Jamf is done executing the policy. This does not give the user a chance to review the status and read the final message update.

To resolve this issue, I added a wait statement before the exit "${exitCode}" in the finalise function.
@pyther pyther added the enhancement New feature or request label Aug 24, 2022
@dan-snelson
Copy link
Owner

Nice, @pyther.

You're welcome to submit a PR (after I fix Issue #3).

@master-vodawagner
Copy link

@pyther

Can you supply the wait statement you added? I'm encountering a similar issue with Jamf closing the dialog too quickly

@pyther
Copy link
Author

pyther commented Sep 2, 2022

PR: #5

@dan-snelson
Copy link
Owner

https://snelson.us/2022/09/setup-your-mac-via-swiftdialog-1-2-7/#completion-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-snelson dan-snelson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pyther @dan-snelson @master-vodawagner