difference between workerd and worker in conditions

[himself65]

I noticed that waku is using workerd in the import conditions.

waku/packages/waku/src/lib/handlers/dev-worker-impl.ts

Lines 139 to 140 in a7e909f

	conditions: ['react-server', 'workerd'],
	externalConditions: ['react-server', 'workerd'],

I think this is not correct. workerd is an alias for Cloudflare workers; I guess you are mentioning worker, which is for the web worker.

https://developers.cloudflare.com/workers/wrangler/bundling/#conditional-exports

[himself65]

one example in the real world

https://github.com/facebook/react/blob/5c607369ceebe56d85175df84b7b6ad58dd25e1f/packages/react-dom/package.json#L56-L59

Webpack document:

https://webpack.js.org/guides/package-exports/#providing-nodejs-webworker-and-browser-versions

[dai-shi]

https://github.com/facebook/react/blob/5c607369ceebe56d85175df84b7b6ad58dd25e1f/packages/react-server-dom-webpack/package.json#L52

I specifically meant server.edge.

We can try server.browser if it has the capability we use, but we need to adjust everything.

[dai-shi]

This is intentional for the moment. I wonder how we do it in the future. Each approach seems to have pros and cons.

[dai-shi]

#394 (comment)

My idea is to use different outputs for different distributions.

We may try that in the future, once it has settled a bit more.

[dai-shi]

somewhat related: #480