Skip to content

Commit 9fe5ad9

Browse files
Ulrich Dreppertorvalds
Ulrich Drepper
authored andcommitted
flag parameters add-on: remove epoll_create size param
Remove the size parameter from the new epoll_create syscall and renames the syscall itself. The updated test program follows. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #include <fcntl.h> #include <stdio.h> #include <time.h> #include <unistd.h> #include <sys/syscall.h> #ifndef __NR_epoll_create2 # ifdef __x86_64__ # define __NR_epoll_create2 291 # elif defined __i386__ # define __NR_epoll_create2 329 # else # error "need __NR_epoll_create2" # endif #endif #define EPOLL_CLOEXEC O_CLOEXEC int main (void) { int fd = syscall (__NR_epoll_create2, 0); if (fd == -1) { puts ("epoll_create2(0) failed"); return 1; } int coe = fcntl (fd, F_GETFD); if (coe == -1) { puts ("fcntl failed"); return 1; } if (coe & FD_CLOEXEC) { puts ("epoll_create2(0) set close-on-exec flag"); return 1; } close (fd); fd = syscall (__NR_epoll_create2, EPOLL_CLOEXEC); if (fd == -1) { puts ("epoll_create2(EPOLL_CLOEXEC) failed"); return 1; } coe = fcntl (fd, F_GETFD); if (coe == -1) { puts ("fcntl failed"); return 1; } if ((coe & FD_CLOEXEC) == 0) { puts ("epoll_create2(EPOLL_CLOEXEC) set close-on-exec flag"); return 1; } close (fd); puts ("OK"); return 0; } ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Ulrich Drepper <drepper@redhat.com> Acked-by: Davide Libenzi <davidel@xmailserver.org> Cc: Michael Kerrisk <mtk.manpages@googlemail.com> Cc: <linux-arch@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent e38b36f commit 9fe5ad9

File tree

7 files changed

+17
-15
lines changed

7 files changed

+17
-15
lines changed

arch/x86/ia32/ia32entry.S

+1-1
Original file line numberDiff line numberDiff line change
@@ -828,7 +828,7 @@ ia32_sys_call_table:
828828
.quad compat_sys_timerfd_gettime
829829
.quad compat_sys_signalfd4
830830
.quad sys_eventfd2
831-
.quad sys_epoll_create2
831+
.quad sys_epoll_create1
832832
.quad sys_dup3 /* 330 */
833833
.quad sys_pipe2
834834
.quad sys_inotify_init1

arch/x86/kernel/syscall_table_32.S

+1-1
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ ENTRY(sys_call_table)
328328
.long sys_timerfd_gettime
329329
.long sys_signalfd4
330330
.long sys_eventfd2
331-
.long sys_epoll_create2
331+
.long sys_epoll_create1
332332
.long sys_dup3 /* 330 */
333333
.long sys_pipe2
334334
.long sys_inotify_init1

fs/eventpoll.c

+10-8
Original file line numberDiff line numberDiff line change
@@ -1046,7 +1046,7 @@ static int ep_poll(struct eventpoll *ep, struct epoll_event __user *events,
10461046
* RB tree. With the current implementation, the "size" parameter is ignored
10471047
* (besides sanity checks).
10481048
*/
1049-
asmlinkage long sys_epoll_create2(int size, int flags)
1049+
asmlinkage long sys_epoll_create1(int flags)
10501050
{
10511051
int error, fd = -1;
10521052
struct eventpoll *ep;
@@ -1058,14 +1058,13 @@ asmlinkage long sys_epoll_create2(int size, int flags)
10581058
return -EINVAL;
10591059

10601060
DNPRINTK(3, (KERN_INFO "[%p] eventpoll: sys_epoll_create(%d)\n",
1061-
current, size));
1061+
current, flags));
10621062

10631063
/*
1064-
* Sanity check on the size parameter, and create the internal data
1065-
* structure ( "struct eventpoll" ).
1064+
* Create the internal data structure ( "struct eventpoll" ).
10661065
*/
1067-
error = -EINVAL;
1068-
if (size <= 0 || (error = ep_alloc(&ep)) < 0) {
1066+
error = ep_alloc(&ep);
1067+
if (error < 0) {
10691068
fd = error;
10701069
goto error_return;
10711070
}
@@ -1081,14 +1080,17 @@ asmlinkage long sys_epoll_create2(int size, int flags)
10811080

10821081
error_return:
10831082
DNPRINTK(3, (KERN_INFO "[%p] eventpoll: sys_epoll_create(%d) = %d\n",
1084-
current, size, fd));
1083+
current, flags, fd));
10851084

10861085
return fd;
10871086
}
10881087

10891088
asmlinkage long sys_epoll_create(int size)
10901089
{
1091-
return sys_epoll_create2(size, 0);
1090+
if (size < 0)
1091+
return -EINVAL;
1092+
1093+
return sys_epoll_create1(0);
10921094
}
10931095

10941096
/*

include/asm-x86/unistd_32.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@
334334
#define __NR_timerfd_gettime 326
335335
#define __NR_signalfd4 327
336336
#define __NR_eventfd2 328
337-
#define __NR_epoll_create2 329
337+
#define __NR_epoll_create1 329
338338
#define __NR_dup3 330
339339
#define __NR_pipe2 331
340340
#define __NR_inotify_init1 332

include/asm-x86/unistd_64.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -645,8 +645,8 @@ __SYSCALL(__NR_paccept, sys_paccept)
645645
__SYSCALL(__NR_signalfd4, sys_signalfd4)
646646
#define __NR_eventfd2 290
647647
__SYSCALL(__NR_eventfd2, sys_eventfd2)
648-
#define __NR_epoll_create2 291
649-
__SYSCALL(__NR_epoll_create2, sys_epoll_create2)
648+
#define __NR_epoll_create1 291
649+
__SYSCALL(__NR_epoll_create1, sys_epoll_create1)
650650
#define __NR_dup3 292
651651
__SYSCALL(__NR_dup3, sys_dup3)
652652
#define __NR_pipe2 293

include/linux/eventpoll.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#include <linux/fcntl.h>
1919
#include <linux/types.h>
2020

21-
/* Flags for epoll_create2. */
21+
/* Flags for epoll_create1. */
2222
#define EPOLL_CLOEXEC O_CLOEXEC
2323

2424
/* Valid opcodes to issue to sys_epoll_ctl() */

include/linux/syscalls.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ asmlinkage long sys_poll(struct pollfd __user *ufds, unsigned int nfds,
431431
asmlinkage long sys_select(int n, fd_set __user *inp, fd_set __user *outp,
432432
fd_set __user *exp, struct timeval __user *tvp);
433433
asmlinkage long sys_epoll_create(int size);
434-
asmlinkage long sys_epoll_create2(int size, int flags);
434+
asmlinkage long sys_epoll_create1(int flags);
435435
asmlinkage long sys_epoll_ctl(int epfd, int op, int fd,
436436
struct epoll_event __user *event);
437437
asmlinkage long sys_epoll_wait(int epfd, struct epoll_event __user *events,

0 commit comments

Comments
 (0)