Merge pull request swiftlang#180 from dabelknap/enumnamespace-modifiers

UseEnumForNamespacing: Remove the 'final' keyword when transforming from a class

Author: allevato

Sources/SwiftFormatRules/UseEnumForNamespacing.swift

@@ -66,8 +66,9 @@ public final class UseEnumForNamespacing: SyntaxFormatRule {
     name: TokenSyntax,
     members: MemberDeclBlockSyntax
   ) -> EnumDeclSyntax {
+    let newModifiers = modifiers?.remove(name: "final")
     return EnumDeclSyntax {
-      if let mods = modifiers {
+      if let mods = newModifiers {
         for mod in mods { $0.addModifier(mod) }
       }
       $0.useEnumKeyword(declarationKeyword.withKind(.enumKeyword))

Tests/SwiftFormatRulesTests/UseEnumForNamespacingTests.swift

@@ -21,6 +21,9 @@ public class UseEnumForNamespacingTests: DiagnosingTestCase {
              class C {
                static func foo() {}
              }
+             public final class D {
+               static func bar()
+             }
              """,
       expected: """
                 enum A {
@@ -34,6 +37,9 @@ public class UseEnumForNamespacingTests: DiagnosingTestCase {
                 enum C {
                   static func foo() {}
                 }
+                public enum D {
+                  static func bar()
+                }
                 """)
   }