Skip to content

Commit a08a8c4

Browse files
mattipcyyever
authored andcommitted
DOC: create 1.12 docs from a tag like v1.12.2rc1 (#71985)
Summary: brianjo, malfet The documentation team would prefer the [documentation versions] to only have a major.minor version, not major.minor.patch. See also pytorch/pytorch.github.io#921 The regex can be tested by this bash 1-liner (where $tag is something like `v10.1225.0rc1`) ``` echo $tag | sed -e 's/v*\([0-9]*\.[0-9]*\).*/\1/' ``` I have lost track a bit, is the CI run for a tag actually building and pushing documentation? Pull Request resolved: pytorch/pytorch#71985 Reviewed By: mrshenli Differential Revision: D33845882 Pulled By: malfet fbshipit-source-id: 3cb644d8b01f5ddf87c0ac7c43e23e9fd292d660 (cherry picked from commit f884bd8)
1 parent d76aebc commit a08a8c4

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

.circleci/config.yml

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.circleci/verbatim-sources/job-specs/job-specs-custom.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343
set -ex
4444
export COMMIT_DOCKER_IMAGE=${DOCKER_IMAGE}:build-${DOCKER_TAG}-${CIRCLE_SHA1}
4545
echo "DOCKER_IMAGE: "${COMMIT_DOCKER_IMAGE}
46-
# turn v1.12.0rc3 into 1.12.0
47-
tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9.]*\).*/\1/')
46+
# turn v1.12.0rc3 into 1.12
47+
tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9]*\.[0-9]*\).*/\1/')
4848
target=${tag:-master}
4949
echo "building for ${target}"
5050
time docker pull ${COMMIT_DOCKER_IMAGE} >/dev/null
@@ -89,9 +89,8 @@
8989
set -ex
9090
export COMMIT_DOCKER_IMAGE=${DOCKER_IMAGE}:build-${DOCKER_TAG}-${CIRCLE_SHA1}
9191
echo "DOCKER_IMAGE: "${COMMIT_DOCKER_IMAGE}
92-
# turn v1.12.0rc3 into 1.12.0
93-
tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9.]*\).*/\1/')
94-
tag=${CIRCLE_TAG:1:5}
92+
# turn v1.12.0rc3 into 1.12
93+
tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9]*\.[0-9]*\).*/\1/')
9594
target=${tag:-master}
9695
echo "building for ${target}"
9796
time docker pull ${COMMIT_DOCKER_IMAGE} >/dev/null

0 commit comments

Comments
 (0)