mysqldump-secure: documentation and multi-php fix. #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `MYSQL_BACKUP_USER` * `MYSQL_BACKUP_PASS` * `MYSQL_BACKUP_HOST` In case they are missing from the `.env` file, the `mysqldump-secure` command cannot be run successfully on containers other than the default one. [Related piece of code](https://github.com/devilbox/docker-php-fpm/blob/042023514ddb26289f7fe7565dc03eadfdc56bff/Dockerfiles/slim/data/docker-entrypoint.sh#L191) which is responsible for the generation of the mysqldump-secure configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issue #985
PR contains two commits, one only for documentation, one for
ymlfix, both are related to the same issue.Goal
Improve documentation and prevent future misunderstandings due to the user being unaware of certain variables.
Add missing mounts for the multi PHP setup.
Description
Documentation Commit
The following variables:
MYSQL_BACKUP_USERMYSQL_BACKUP_PASSMYSQL_BACKUP_HOSTAre used for generating the
mysqldump-secureconfiguration file as can be seen hereIn case they are missing from the
.envfile, themysqldump-securecommand cannot be run successfully on containers other than the default one due to different username/password.Multi PHP issue
Here the issue was that the
backupsdirectory was not mounting to the given container, probably because of the missing declaration. Was added and tested, nowmysqldump-secureshould be able to write to the host directory regardless from which container it is started.