v0.7.0-beta2 Hotfixes (#169)

Author: talenfisher

.github/releases/v0.7.0-beta3.md

@@ -1,3 +1,5 @@
-Enhancements:
 
-- 
+Bug Fixes:
+
+- Fixed an issue where the generator would attempt to generate validations for collection types, which would result in a stack overflow.  The validations generator no longer recurses into these types, or any type that lives in an assembly that starts with "System"
+- Fixed an issue where validations were being generated for private and protected properties.

src/Generator/ValidationsGenerator.cs

@@ -55,10 +55,13 @@ public IEnumerable<StatementSyntax> GenerateValidations(INamedTypeSymbol? typeTo
         {
             typeToValidate ??= this.typeToValidate;
 
-            var members = typeToValidate.GetMembers().OfType<IPropertySymbol>() ?? ImmutableArray<IPropertySymbol>.Empty;
-            foreach (var member in members)
+            var members = from member in typeToValidate.GetMembers().OfType<IPropertySymbol>()
+                          where member.DeclaredAccessibility == Accessibility.Public
+                          select member;
+
+            foreach (var member in members ?? ImmutableArray<IPropertySymbol>.Empty)
             {
-                if (member.Type is INamedTypeSymbol memberType && memberType.ContainingAssembly.Name != "System")
+                if (member.Type is INamedTypeSymbol memberType && !memberType.ContainingAssembly.Name.StartsWith("System"))
                 {
                     ExpressionSyntax newParentExpression = parentExpression == null
                         ? ConditionalAccessExpression(

tests/Compilation/Projects/CustomResources/ResourceProperties.cs

@@ -1,3 +1,4 @@
+using System.Collections.Generic;
 using System.ComponentModel.DataAnnotations;
 
 namespace Lambdajection.CompilationTests.CustomResources
@@ -9,6 +10,10 @@ public class ResourceProperties
 
         public bool ShouldFail { get; set; } = false;
 
+        // This is a test - the validations generator should not recurse into collection types
+        // (it will cause a stack overflow if it does recurse, so simply running it will suffice)
+        public List<string> ValidationsGeneratorShouldNotRecurseIntoCollections { get; set; }
+
         public string ErrorMessage { get; set; } = string.Empty;
     }
 }