Skip to content

Add dist/index.metadata.json to cleanup and fix typo dist/LICENSE #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2017

Conversation

beeman
Copy link
Contributor

@beeman beeman commented Jan 17, 2017

Hi @cyrilletuzi,

First of all thanks for this module and your blog! It showed my how to create Angular modules that can be used in other projects, just what I needed.

I have taken the project and stripped it to a starter that I can use to easily create new modules. I am looking at building a generator for it. Obviously with credit for the initial implementation to you.

In the process I found 2 small issues in the cleanup script, this PR fixes those.

Cheers B

@beeman
Copy link
Contributor Author

beeman commented Jan 17, 2017

Btw, some other small adjustments I made are these:

Let me know if you want these added to the PR too :)

@cyrilletuzi cyrilletuzi merged commit 9655656 into cyrilletuzi:master Jan 17, 2017
@cyrilletuzi
Copy link
Owner

Thanks for this PR !

About excluding files in dist, even if they are just build files, I prefer to keep them on github as it's what npm users get, so they can explore them if they want (even if they can do so locally).

@cyrilletuzi cyrilletuzi mentioned this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants