Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL Log injection #1011

Closed
spicyli opened this issue Aug 29, 2023 · 2 comments
Closed

CodeQL Log injection #1011

spicyli opened this issue Aug 29, 2023 · 2 comments

Comments

@spicyli
Copy link

spicyli commented Aug 29, 2023

Hello!

We're seeing some Codeql Log Injection errors coming from the examples

I'm aware these are merely examples for legacy versions of cypress, but I'm wondering if there are any plans to deprecate these over time (if so when) and/or if there are any plans to fix these?

Thanks!

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Aug 29, 2023

@spicyli

The v9 examples have been removed from the default branch and they are no longer maintained.

https://github.com/rtkwlf-actions says "This organization has no public repositories." so I can't read from your link.
The link https://github.com/rtkwlf-actions/cypress-io-github-action/blob/73fc04a0729a5f83d5619c2f53d35f92fb352089/examples/v9/wait-on/index.js#L25 you provided gives a 404 error.

If you have a fork of this repo and you sync with the master (default) branch, then the v9 examples will be removed. The removal / archiving is mentioned in the current README.

@spicyli
Copy link
Author

spicyli commented Aug 29, 2023

Thanks a lot @MikeMcC399 will do so

@spicyli spicyli closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants