-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve UX when Test Replay upload fails due to slow upload #30235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consolidatd args for stream stall msg
cypress Run #57310
Run Properties:
|
Project |
cypress
|
Branch Review |
cacie/9143/stream-stall-enhancements
|
Run status |
Passed #57310
|
Run duration | 25m 47s |
Commit |
cf342cfc2c: changelog
|
Committer | Cacie Prins |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
7
|
Pending |
1326
|
Skipped |
0
|
Passing |
29395
|
View all changes introduced in this branch ↗︎ |
UI Coverage
44.77%
|
|
---|---|
Untested elements |
201
|
Tested elements |
167
|
Accessibility
91.28%
|
|
---|---|
Failed rules |
5 critical
10 serious
2 moderate
2 minor
|
Failed elements |
944
|
MikeMcC399
reviewed
Sep 13, 2024
cacieprins
requested review from
AtofStryker,
ryanjwilke and
ryanthemanuel
and removed request for
ryanjwilke
September 13, 2024 17:26
jennifer-shehane
requested changes
Sep 18, 2024
ryanthemanuel
approved these changes
Sep 24, 2024
jennifer-shehane
approved these changes
Sep 25, 2024
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Cypress monitors the upload of a Test Replay recording. If the upload speed drops below 102.4kbps over a period of five seconds, Cypress terminates the upload so that CI pipelines are not unnecessarily slowed. This value is determined by:
This PR changes that behavior such that:
Steps to test
CYPRESS_PROTOCOL_UPLOAD_SAMPLING_INTERVAL
environment variable. If your bandwidth is set to 56kbps, for example, you should set the sampling interval to at least ten seconds (at 56kbps, it should take just over 9 seconds to transfer 512kb, or 64 kiloBytes)How has the user experience changed?
A new stream stall error message:
A new uncategorized error message:
PR Tasks
cypress-documentation
?type definitions
?