feat: add angular-ct project setup #22897
Conversation
|
Thanks for taking the time to open a PR!
|
|
Need to scaffold |
| package: '@angular/cli', | ||
| installer: '@angular/cli', | ||
| description: 'CLI tool that you use to initialize, develop, scaffold, and maintain Angular applications.', | ||
| minVersion: '>=13.0.0', |
There was a problem hiding this comment.
Do we also want to include a maxVersion? (not sure we actually have code path supporting this, but it would be easy to add, I think).
Also, do we know this does not work with any other versions (like 12 or 14)?
There was a problem hiding this comment.
Actually we can add a maxVersion here: #22890
Question still stands about other versions - do we have support for 12 or 14?
There was a problem hiding this comment.
No support for 12 but 14 works (and is proven out in the system tests)
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
| }, null, 2) | ||
|
|
||
| return extractProperty(` | ||
| const toMerge = ${componentConfig} |
There was a problem hiding this comment.
Hm I would expect this would have changed the indentation. Or do we handle the formatting elsewhere 🤔
There was a problem hiding this comment.
Right above is the JSON.stringify(..., null, 2) which indents properly.
lmiller1990
left a comment
lmiller1990
left a comment
There was a problem hiding this comment.
One question, giving it a test now.
|
I tried it out, works great!
|
lmiller1990
left a comment
lmiller1990
left a comment
There was a problem hiding this comment.
Comments addressed and I tested it out, works great 👍
mike-plummer
left a comment
mike-plummer
left a comment
There was a problem hiding this comment.
LGTM, just one question
User facing changelog
Detect and scaffold CT project files for Angular applications
Additional details
Adding a new framework is fairly straightforward as it is all configuration based. Most of the code changes are from added system tests. The mount and dev-server handler PRs need to be merged before this can land.
Steps to test
ng new angular-app(Might need to install ng globally withnpm i -g @angular/cli)yarn cypress:openin cypress repo and point it at the new Angular applicationWon't work until the Angular infra is in which should be soon. You can also run the
packages/launchpad/cypress/e2e/scaffold-component-testing.cy.ts -> angular-cli-unconfiguredtest in the launchpad.How has the user experience changed?
Screen.Recording.2022-07-22.at.11.45.37.AM.mov
PR Tasks
cypress-documentation?type definitions?