-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore: rename DEBUG cypress-trace -> trace-cypress #21658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI these logs were extremely helpful during some recent debugging, thanks for this.
@@ -12,7 +12,7 @@ const debugLibCache: Record<string, debugLib.Debugger> = {} | |||
* set DEBUG=cypress-trace:<ClassName> to utilize the logging | |||
*/ | |||
export function autoBindDebug <T extends object> (obj: T): T { | |||
const ns = `cypress-trace:${obj.constructor.name}` | |||
const ns = `trace-cypress:${obj.constructor.name}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could document this in packages/data-context/README.md
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, will do that before I merge
User facing changelog
N/A
Additional details
Follow re: #21621, makes
cypress*
a bit more tolerable, by moving theautoBindDebug
helper which is only meant for advanced race-condition debugging totrace-cypress
debug namespaceSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?