Skip to content

chore: rename DEBUG cypress-trace -> trace-cypress #21658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

tgriesser
Copy link
Member

  • Closes N/A

User facing changelog

N/A

Additional details

Follow re: #21621, makes cypress* a bit more tolerable, by moving the autoBindDebug helper which is only meant for advanced race-condition debugging to trace-cypress debug namespace

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 27, 2022

Thanks for taking the time to open a PR!

@tgriesser tgriesser requested a review from flotwig May 27, 2022 13:45
@cypress
Copy link

cypress bot commented May 27, 2022



Test summary

37537 0 454 0Flakiness 6


Run details

Project cypress
Status Passed
Commit e3f42de
Started May 27, 2022 1:42 PM
Ended May 27, 2022 2:03 PM
Duration 20:14 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
commands/querying/querying.cy.js Flakiness
1 ... > route aliases > returns an array of xhrs when dots in alias name
commands/net_stubbing.cy.ts Flakiness
1 network stubbing > waiting and aliasing > yields the expected interception when two requests are raced
2 network stubbing > intercepting response > can throttle a proxy response using res.setThrottle
e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tgriesser tgriesser requested a review from tbiethman May 27, 2022 14:29
Copy link
Contributor

@tbiethman tbiethman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI these logs were extremely helpful during some recent debugging, thanks for this.

@@ -12,7 +12,7 @@ const debugLibCache: Record<string, debugLib.Debugger> = {}
* set DEBUG=cypress-trace:<ClassName> to utilize the logging
*/
export function autoBindDebug <T extends object> (obj: T): T {
const ns = `cypress-trace:${obj.constructor.name}`
const ns = `trace-cypress:${obj.constructor.name}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could document this in packages/data-context/README.md as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will do that before I merge

@tgriesser tgriesser merged commit 292f8b4 into develop May 31, 2022
@tgriesser tgriesser deleted the tgriesser/chore/cleanup-debug-trace branch May 31, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants