Skip to content

feat(driver): Unselect all selected options with cy.select([]) #18329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2021
Merged

feat(driver): Unselect all selected options with cy.select([]) #18329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84e8ee2
allow select to be called with empty array
davidmunechika Sep 30, 2021
ffe86d2
Merge branch 'develop' into issue-4318-empty-array-clear-select
davidmunechika Oct 1, 2021
3c2f558
Merge branch 'develop' into issue-4318-empty-array-clear-select
davidmunechika Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions packages/driver/cypress/integration/commands/actions/select_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,14 @@ describe('src/cy/commands/actions/select', () => {
})
})

it('unselects all options if called with empty array', () => {
cy.get('select[name=movies]').select(['apoc', 'br'])

cy.get('select[name=movies]').select([]).then(($select) => {
expect($select.val()).to.deep.eq([])
})
})

// readonly should only be limited to inputs, not checkboxes
it('can select a readonly select', () => {
cy.get('select[name=hunter]').select('gon').then(($select) => {
Expand Down Expand Up @@ -505,17 +513,6 @@ describe('src/cy/commands/actions/select', () => {
cy.get('select[name=foods]').select('')
})

it('throws invalid array argument error when called with empty array', (done) => {
cy.on('fail', (err) => {
expect(err.message).to.include('`cy.select()` must be passed an array containing only strings and/or numbers. You passed: `[]`')
expect(err.docsUrl).to.eq('https://on.cypress.io/select')

done()
})

cy.get('select[name=foods]').select([])
})

it('throws invalid array argument error when called with invalid array', (done) => {
cy.on('fail', (err) => {
expect(err.message).to.include('`cy.select()` must be passed an array containing only strings and/or numbers. You passed: `[true,false]`')
Expand Down
8 changes: 3 additions & 5 deletions packages/driver/src/cy/commands/actions/select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,8 @@ export default (Commands, Cypress, cy) => {

if (
_.isArray(valueOrTextOrIndex)
&& (
valueOrTextOrIndex.length === 0
|| !_.some(valueOrTextOrIndex, (val) => _.isNumber(val) || _.isString(val))
)
&& valueOrTextOrIndex.length > 0
&& !_.some(valueOrTextOrIndex, (val) => _.isNumber(val) || _.isString(val))
) {
$errUtils.throwErrByPath('select.invalid_array_argument', { args: { value: JSON.stringify(valueOrTextOrIndex) } })
}
Expand Down Expand Up @@ -163,7 +161,7 @@ export default (Commands, Cypress, cy) => {
})
}

if (!values.length) {
if (!values.length && !(_.isArray(valueOrTextOrIndex) && valueOrTextOrIndex.length === 0)) {
$errUtils.throwErrByPath('select.no_matches', {
args: { value: valueOrTextOrIndex.join(', ') },
})
Expand Down