Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

videoRecording option is not clear / mixes Dashboard verbiage #562

Closed
brian-mann opened this issue Jul 12, 2017 · 3 comments · Fixed by #1804
Closed

videoRecording option is not clear / mixes Dashboard verbiage #562

brian-mann opened this issue Jul 12, 2017 · 3 comments · Fixed by #1804
Assignees
@brian-mann
Labels
topic: video 📹 type: user experience Improvements needed for UX
Milestone
3.0.0

Comments

@brian-mann
Copy link
Member

Per this doc: https://docs.cypress.io/guides/references/configuration.html#Videos

The word record is used in two different contexts.

For instance we refer to "recording your run" when we upload assets to our Dashboard and provide you with the results.

We also refer to capturing the actual video of the run as videoRecording with the description text of: Whether Cypress will record a video of the test run when running headlessly.

This is confusing and I suggest we rename this option to be videoCapture since its really just about whether or not we record the frames of the run and output a .mp4 at the end.

Unless the --record flag is passed and you provide us your Record Key, we'll still capture a video but just not "record" it on the Dashboard.
@brian-mann brian-mann added type: enhancement Requested enhancement of existing feature type: unexpected behavior User expected result, but got another labels Jul 12, 2017
@brian-mann
Copy link
Member Author

Thinking about renaming videoRecording to videoCapture in 2.0.0

@brian-mann brian-mann modified the milestones: 2, 2.0.0 Dec 29, 2017
@brian-mann brian-mann mentioned this issue Dec 29, 2017
Closed
@jennifer-shehane jennifer-shehane added stage: proposal 💡 No work has been done of this issue type: user experience Improvements needed for UX and removed type: enhancement Requested enhancement of existing feature type: unexpected behavior User expected result, but got another labels Dec 29, 2017
@jennifer-shehane jennifer-shehane modified the milestones: 2.0.0, 3.0.0 Feb 16, 2018
@jennifer-shehane jennifer-shehane added stage: ready for work The issue is reproducible and in scope and removed stage: proposal 💡 No work has been done of this issue labels Apr 11, 2018
@brian-mann brian-mann self-assigned this May 14, 2018
@brian-mann
Copy link
Member Author

Renaming this from videoRecording to just video in 3.0.0

@brian-mann brian-mann mentioned this issue May 29, 2018
Merged
@brian-mann
Copy link
Member Author

Released in 3.0.0.

@jennifer-shehane jennifer-shehane removed stage: ready for work The issue is reproducible and in scope labels Jan 16, 2019
@brian-mann brian-mann mentioned this issue Jan 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
topic: video 📹 type: user experience Improvements needed for UX
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

rename videoRecording -> video cypress-io/cypress
2 participants
@brian-mann @jennifer-shehane