Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where Chrome policy warnings are not active #4986

Closed
flotwig opened this issue Aug 14, 2019 · 3 comments · Fixed by #4720
Closed

Fix bug where Chrome policy warnings are not active #4986

flotwig opened this issue Aug 14, 2019 · 3 comments · Fixed by #4720
Assignees
@flotwig
Labels
type: regression A bug that didn't appear until a specific Cy version release

Comments

@flotwig
Copy link
Contributor

flotwig commented Aug 14, 2019

Current behavior:

registry-js is not included in the final binary, so Chrome policy checks from #4391 don't happen

Desired behavior:

Ship this optionalDependency so the policy checks do happen.
@flotwig flotwig self-assigned this Aug 14, 2019
@flotwig flotwig mentioned this issue Aug 14, 2019
Merged
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Sep 12, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Sep 24, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 24, 2019

The code for this is done in cypress-io/cypress#4720, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

1 similar comment
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 24, 2019

The code for this is done in cypress-io/cypress#4720, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane jennifer-shehane added the type: regression A bug that didn't appear until a specific Cy version release label Oct 2, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flotwig flotwig

Labels
type: regression A bug that didn't appear until a specific Cy version release
Projects
None yet
Milestone
No milestone
2 participants
@flotwig @jennifer-shehane